Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a service class is deprecated, the service factory should be deprecated as well #1077

Open
nozzlegear opened this issue Jul 3, 2024 · 0 comments
Open

If a service class is deprecated, the service factory should be deprecated as well #1077

nozzlegear opened this issue Jul 3, 2024 · 0 comments
Labels
deprecated class or method Deals with a class or method in ShopifySharp that is, should, or will be deprecated. enhancement

Comments

@nozzlegear
Copy link
Owner

To be sure that developers notice deprecation warnings, I'd like the service factory generator to mark a service factory as deprecated if its service is deprecated. For example, the CountryService was just deprecated, but neither the CountryServiceFactory and ICountryServiceFactory interface are deprecated. If a developer only uses those in their application, then they may not know about the deprecation until the factories simply disappear in a future release.
@nozzlegear nozzlegear added enhancement deprecated class or method Deals with a class or method in ShopifySharp that is, should, or will be deprecated. labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecated class or method Deals with a class or method in ShopifySharp that is, should, or will be deprecated. enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nozzlegear