Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate most GraphService methods and converge on two standard methods #1051

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Commits on Oct 5, 2024

  1. Deprecate most GraphService public methods and converge on two public…

    … methods
    
    This change deprecates most GraphService.PostAsync and GraphService.SendAsync methods, of which there were at least six total. It introduces two new GraphService.PostAsync methods to replace them all, which standardize the usage of the `GraphRequest` class and serializing all requests to json.
    
    Previously, some of the PostAsync/SendAsync methods would serialize the request to json, some wouldn't. Some would send the variables, some wouldn't. Some would let you set your own json wherein you could apply the variables yourself, but then they'd send the `application/graphql` content-type, which made Shopify ignore any variables sent.
    nozzlegear committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    3739df1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    414224e View commit details
    Browse the repository at this point in the history
  3. Use file-scoped namespace

    nozzlegear committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    694964c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Refactor GraphService methods and error handling, and introduce Parse…

    …dGraphResponse class for deserializing GraphQL responses
    
    Changes:
    
    - Introduced a new class named `ParsedGraphResponse<T>` to be used for deserializing Shopify's GraphQL responses. It includes two properties: `Data` of type `T` and `UserErrors` of type `ICollection<UserError>`.
    - Modified the error handling logic in `GraphService` to use the new `ParsedGraphResponse<T>` class.
    - Refactored all public methods in `GraphService` to use the same internal method for calling the GraphQL API. Tests will be added to ensure the obsoleted methods have not been broken.
    - Deprecated `GraphService.CheckForErrors<T>`
    nozzlegear committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ef49555 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eafd23e View commit details
    Browse the repository at this point in the history
  3. Allow dev to disable error handling in GraphService

    Type: feature
    nozzlegear committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    f6dac51 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0f95242 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    36cf554 View commit details
    Browse the repository at this point in the history
  6. Add GraphExtensions object

    nozzlegear committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5dd763a View commit details
    Browse the repository at this point in the history
  7. Remove JsonProperty and JsonPropertyName attributes

    Planning to use a camel case property name strategy with System.Text.Json instead.
    nozzlegear committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    89d907b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    33da287 View commit details
    Browse the repository at this point in the history
  9. Update xml docs

    nozzlegear committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8e15fe8 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Reorganize GraphService test files

    Type: chore
    nozzlegear committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    db080be View commit details
    Browse the repository at this point in the history
  2. Add FakeItEasy package

    Type: chore
    nozzlegear committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    94df13d View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    56c2a7d View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Add Xunit.Combinatorial

    nozzlegear committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    ac34e9c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e787bb7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f1b4f21 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    581729f View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Replace JsonProperty with JsonPropertyName

    Worried about too much memory usage/potential memory leaks by using JsonElement for unknown, potentially gigantic json values in an exception.
    nozzlegear committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    e77ba28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bf2dd0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    72a49eb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9e86adb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    405b49e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    63b0942 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    31a0359 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c8972f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    820ccf1 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2024

  1. Configuration menu
    Copy the full SHA
    1b92e9a View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Configuration menu
    Copy the full SHA
    33c72b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ae8208a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0b75d77 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Configuration menu
    Copy the full SHA
    4daf9f1 View commit details
    Browse the repository at this point in the history