-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate most GraphService methods and converge on two standard methods #1051
base: master
Are you sure you want to change the base?
Commits on Oct 5, 2024
-
Deprecate most GraphService public methods and converge on two public…
… methods This change deprecates most GraphService.PostAsync and GraphService.SendAsync methods, of which there were at least six total. It introduces two new GraphService.PostAsync methods to replace them all, which standardize the usage of the `GraphRequest` class and serializing all requests to json. Previously, some of the PostAsync/SendAsync methods would serialize the request to json, some wouldn't. Some would send the variables, some wouldn't. Some would let you set your own json wherein you could apply the variables yourself, but then they'd send the `application/graphql` content-type, which made Shopify ignore any variables sent.
Configuration menu - View commit details
-
Copy full SHA for 3739df1 - Browse repository at this point
Copy the full SHA 3739df1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 414224e - Browse repository at this point
Copy the full SHA 414224eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 694964c - Browse repository at this point
Copy the full SHA 694964cView commit details
Commits on Oct 11, 2024
-
Refactor GraphService methods and error handling, and introduce Parse…
…dGraphResponse class for deserializing GraphQL responses Changes: - Introduced a new class named `ParsedGraphResponse<T>` to be used for deserializing Shopify's GraphQL responses. It includes two properties: `Data` of type `T` and `UserErrors` of type `ICollection<UserError>`. - Modified the error handling logic in `GraphService` to use the new `ParsedGraphResponse<T>` class. - Refactored all public methods in `GraphService` to use the same internal method for calling the GraphQL API. Tests will be added to ensure the obsoleted methods have not been broken. - Deprecated `GraphService.CheckForErrors<T>`
Configuration menu - View commit details
-
Copy full SHA for ef49555 - Browse repository at this point
Copy the full SHA ef49555View commit details -
Configuration menu - View commit details
-
Copy full SHA for eafd23e - Browse repository at this point
Copy the full SHA eafd23eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f6dac51 - Browse repository at this point
Copy the full SHA f6dac51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f95242 - Browse repository at this point
Copy the full SHA 0f95242View commit details -
Remove IGraphSerializer interface and replace with System.Text.Json's…
… JsonSerializerOptions
Configuration menu - View commit details
-
Copy full SHA for 36cf554 - Browse repository at this point
Copy the full SHA 36cf554View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dd763a - Browse repository at this point
Copy the full SHA 5dd763aView commit details -
Remove JsonProperty and JsonPropertyName attributes
Planning to use a camel case property name strategy with System.Text.Json instead.
Configuration menu - View commit details
-
Copy full SHA for 89d907b - Browse repository at this point
Copy the full SHA 89d907bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33da287 - Browse repository at this point
Copy the full SHA 33da287View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e15fe8 - Browse repository at this point
Copy the full SHA 8e15fe8View commit details
Commits on Oct 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for db080be - Browse repository at this point
Copy the full SHA db080beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94df13d - Browse repository at this point
Copy the full SHA 94df13dView commit details
Commits on Oct 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 56c2a7d - Browse repository at this point
Copy the full SHA 56c2a7dView commit details
Commits on Oct 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ac34e9c - Browse repository at this point
Copy the full SHA ac34e9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e787bb7 - Browse repository at this point
Copy the full SHA e787bb7View commit details -
Iterate through each top-level object in the response json when check…
…ing for userErrors
Configuration menu - View commit details
-
Copy full SHA for f1b4f21 - Browse repository at this point
Copy the full SHA f1b4f21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 581729f - Browse repository at this point
Copy the full SHA 581729fView commit details
Commits on Oct 19, 2024
-
Replace JsonProperty with JsonPropertyName
Worried about too much memory usage/potential memory leaks by using JsonElement for unknown, potentially gigantic json values in an exception.
Configuration menu - View commit details
-
Copy full SHA for e77ba28 - Browse repository at this point
Copy the full SHA e77ba28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0bf2dd0 - Browse repository at this point
Copy the full SHA 0bf2dd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72a49eb - Browse repository at this point
Copy the full SHA 72a49ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e86adb - Browse repository at this point
Copy the full SHA 9e86adbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 405b49e - Browse repository at this point
Copy the full SHA 405b49eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 63b0942 - Browse repository at this point
Copy the full SHA 63b0942View commit details
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 31a0359 - Browse repository at this point
Copy the full SHA 31a0359View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c8972f - Browse repository at this point
Copy the full SHA 6c8972fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 820ccf1 - Browse repository at this point
Copy the full SHA 820ccf1View commit details
Commits on Nov 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1b92e9a - Browse repository at this point
Copy the full SHA 1b92e9aView commit details
Commits on Nov 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 33c72b3 - Browse repository at this point
Copy the full SHA 33c72b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae8208a - Browse repository at this point
Copy the full SHA ae8208aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b75d77 - Browse repository at this point
Copy the full SHA 0b75d77View commit details
Commits on Nov 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4daf9f1 - Browse repository at this point
Copy the full SHA 4daf9f1View commit details