feat: add spinner

[lukekarrys]

Closes #7425

This is a little hard to test because everything should continue to work without progress, as evidenced by the lack of churn in the tests and snapshots here. The only existing tests that changed are the addition of newlines after prompts which is new behavior as part of this PR.

I resorted to manually running some commands to get an idea of how the various states worked together:

node . exec -- npm@4
This should show progress at the start and then hide it as it prompts the user to install npm@4. Ctrl+C should exit from the prompt and the error should display on the next line (this is a current bug).

node . audit signatures --loglevel=http
This should show a lot of http log messages while always keeping the spinner on the last line of output. The spinner also should not jump between frames regardless of how quickly the log messages show up.

node . pack
This should immediately show the banners and output from prepack and not show the spinner until the actual packing is happening.

node . login
The spinner should never while the prompt is being displayed.

node . view npm
The spinner should appear while data is being fetched and then disappear for the rest of the command as output is being displayed. The end output on completion should not have any spinner frames rendered on new lines in the output. The old progress bar achieved this by calling npmlog.disableProgress() but now it is able to hide the spinner appropriately even while outputting individual lines to stdout.

[lukekarrys]

proggy was previously required in display.js as a placeholder for how progress messages could be rendered, but not actually used. I opted to remove it as we now are showing a spinner without any specific messages. A future iteration that should useful progress messages would bring this dependency back.

[lukekarrys]

This is no longer needed because we clear the prompt line in display.js. This is good because currently we wouldn't clear the input in cases besides the emitter's abort event.

[wraithgar]

What's the performance cost here? Is 500 still readable but measurably faster? Ultimately if performance is that important folks should turn this off but ... a sensible default should be something that comes from a place of some testing.

[lukekarrys]

I don't think it should affect performance. This delay is more for UI. A command that only takes 100ms shouldn't attempt to render the spinner since it won't appear as more than a flash of a spinner. I landed on 200ms as the "if nothing has been output yet, let the user know that things are happening". But this number should be very open to changing in the future.

[lukekarrys]

Reading the next comment, I see what you're talking about with the interval frame rate. That number is located in the Progress.dots.duration and Progress.lines.duration and we should also feel free to experiment with those as well.

[wraithgar]

Tested locally. One question about what the default interval should be.

Since pulse-till-done was at 150ms I think this is ok to land as-is but we should definitely be asking ourselves what the "best" interval is.

[lorand-horvath]

@lukekarrys @wraithgar Thanks for taking the time to add the spinner! However, this could be improved upon, compared to how it was before in 10.5.2. My concerns are the following:

1. The spinner is there as expected, but there's a constant blinking cursor overlapping with it and it looks a bit unfinished or buggy.
2. The installation process seems slower. I could revert to 10.5.2 and time the installations to see what the difference is.
3. The spinner is not enough as default information. In previous versions I really liked the way it informed the user about what was currently doing, for example during npm install, so I would very much like to see something of the sort:

\ install react@18.3.1
| install react-dom@18.3.1
/ install styled-components@6.1.9
- update vite@5.2.10
\ update vite-plugin-eslint@1.8.1
| reify etc...

Wouldn't that be nicer?

[HanabishiRecca]

The installation process seems slower.

Measured time with --offline - no difference.

The spinner is not enough as default information.

This. We need more verbosity.