fix: make pack and exec work with git hash refs #7815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milaninfy
force-pushed
the
mm/fix-npx-git-long-sha
branch
from
d79c6de
to
c629c52
Compare
milaninfy
force-pushed
the
mm/fix-npx-git-long-sha
branch
from
c629c52
to
c68b9a0
Compare
milaninfy
force-pushed
the
mm/fix-npx-git-long-sha
branch
from
c68b9a0
to
88615a2
Compare
wraithgar
reviewed
Oct 14, 2024
| @@ -7,6 +7,7 @@ const spawk = tspawk(t) | |||
|
|
|||
| const fs = require('node:fs') | |||
| const path = require('node:path') | |||
| const { resolve } = require('node:path') | |||
There was a problem hiding this comment.
we're already requiring node:path in line 9.
There was a problem hiding this comment.
I'll correct it as chore in next pr whenever I get chance.
wraithgar
reviewed
Oct 14, 2024
|
|
||
| t.test('packs from git spec', async t => { | ||
| const spec = 'test/test#111111aaaaaaaabbbbbbbbccccccdddddddeeeee' | ||
| const pkgPath = path.resolve(__dirname, '../../fixtures/git-test.tgz') |
There was a problem hiding this comment.
I'm not the biggest fan of having this tgz file in fixtures, but if I weigh it against the effort required to build it during tests it makes sense.
wraithgar
approved these changes
Oct 14, 2024
wraithgar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing arborist constructor to pacote.manifest call because internally when fetching git deps DirFetcher requires Arborist constructor from GitFetcher https://github.com/npm/pacote/blob/main/CHANGELOG.md#1400-pre3-2022-09-28
Fixes: #6723