Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

[WIP] separate packagize code into separate dep, pkgize #282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashleygwilliams
Copy link
Contributor

@ashleygwilliams ashleygwilliams commented Oct 31, 2016

fixes #257

pulls packagize code into it's own pkg, pkgize: https://www.npmjs.com/package/pkgize

had to pull token-util into pkgize... should we make that it's own separate pkg? i dont like the repeated code but also don't know if we'll even save pkgize so maybe it doesn't matter?

@ashleygwilliams ashleygwilliams changed the title separate packagize code into separate dep, pkgize [WIP] separate packagize code into separate dep, pkgize Oct 31, 2016
@revin
Copy link
Collaborator

revin commented Nov 1, 2016

@ashleygwilliams Can you please remind me of the reasoning behind this, again? Is it to keep the "npm-ish" stuff out of marky so marky can stick to being a GitHub-style markdown parser? If so, do you think cdn.js should be extracted as well?

@revin
Copy link
Collaborator

revin commented Nov 1, 2016

oh, also re: token-util, it turns out the one function pkgize needs is getText, and no other code in marky needs it, so you should be able to just move getText all by itself without issue.

@ashleygwilliams
Copy link
Contributor Author

@revin - exactly. i'd like marky to be just a GFM parser, and right now it's doing some other stuff. in the long run- i'm not sure the website wants it to do this stuff and so in preparation, i'm separating it out. i think ideally it's code that we can just get rid of all together.

@ashleygwilliams
Copy link
Contributor Author

this is waiting on me moving over the tests. also needs a rebase as this point.

@revin revin removed this from the 10.0.0 milestone Jun 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

separate package related functionality into new package
2 participants