This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can scarcely believe what I'm seeing, but since GitHub now appears to be doing CommonMark compatible parsing, that means we need to remove all of the customizations we so painstakingly assembled over the past few years 😳
CommonMark-compatible processing sometimes results in drastically different output, so I would think GH might be using different renderers depending on when a README was last pushed; however, I haven't checked into this at all.
The first attempt at this PR here just removes all non-CommonMark parsing rules and their tests. Is this what we want? Or do we want the flexibility to render with old-style GitHub rendering (in which case, we'd want to keep everything, but hide it behind an option)?
Fixes #393.