Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitivity of HTTP Response headers #74

Open
uncletammy opened this issue Feb 4, 2014 · 1 comment
Open

Case sensitivity of HTTP Response headers #74

uncletammy opened this issue Feb 4, 2014 · 1 comment

Comments

@uncletammy
Copy link

I have noticed many occasions where frameworks fail to be detected by their HTTP Response headers in Chromesniffer. It appears that while the response header values are converted to lower case before they are compared against the knownHeaders object in background.js, the key names are not converted.

This is resulting in frameworks which issue server responses with X-Powered-By headers instead of x-powered-by headers, not being detected. Would you merge a PR that iterates through the response headers and converts all key names to lower case? Thanks!

@FranklinYu
Copy link

Would you merge a PR that iterates through the response headers and converts all key names to lower case?

@uncletammy Which one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants