Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto-js vulnerability, lessons learned #19

Open
KevinAtSesam opened this issue Feb 1, 2024 · 0 comments
Open

Crypto-js vulnerability, lessons learned #19

KevinAtSesam opened this issue Feb 1, 2024 · 0 comments

Comments

@KevinAtSesam
Copy link
Contributor

Quite a shocking story;

Crypto-js PBKDF2 is 1,000 times weaker than originally specified in 1993, and at least 1,300,000 times weaker than current industry standard. This is because it both (1) defaults to SHA1, a cryptographic hash algorithm considered insecure since at least 2005 and (2) defaults to one single iteration, a 'strength' or 'difficulty' value specified at 1,000 when specified in 1993. PBKDF2 relies on iteration count as a countermeasure to preimage and collision attacks.

GHSA-xwcq-pm8m-c4vf

The impact will be big, since there will be many websites out there with poor password hashing.

Advisories for pbkdf2-scala

  • Warnings when using too few iterations
  • Warnings when using SHA1

By adding these warnings to the application, applications that use pbkdf2-scala can improve their configuration. Since it's quite common to misconfigure pbkdf2, we could do more to assist users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant