[WIP] lib: lte_link_control: refactor into modules

[MirkoCovizzi]

Divides the LTE Link Controller into modules.

Opening for discussion to orient design. It is a work in progress so it is unpolished by design.

Tasks:

• Modularize: make the architecture modular (rather than monolithic) and easy to understand. Streamline the introduction of new AT commands/functionalities. I have a couple of AT commands I need to add so this is important
• Modularize tests to align
• Identify potential configuration problems that might arise from lte_net_if stack, lte_lc API usage within NCS, or custom overlays

Benefits:

• Improved structure
• Improved efficiency because of the increased granularity

What has been changed compared to main:

• Each AT command (or a subset of adjacent AT commands) sits in its own module that can be toggled with a Kconfig option
• The work queue and the event handler list have been moved to a common folder and are shared between the modules

[NordicBuilder]

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 23

Inputs:

Sources:

sdk-nrf: PR head: 356e8d9e928e20d39743096c3b4fc8b95fc85ac0

more details

sdk-nrf:

PR head: 356e8d9e928e20d39743096c3b4fc8b95fc85ac0
merge base: cdbb02a59f05aab6b67cf0cb00b53339d7c290b0
target head (main): d9bf4fb4e36e9dec123f4043b5580e55053c89b5
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (57)

applications
│  ├── asset_tracker_v2
│  │  │ prj.conf
include
│  ├── modem
│  │  │ lte_lc.h
lib
│  ├── location
│  │  │ Kconfig
│  ├── lte_link_control
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── common
│  │  │  ├── CMakeLists.txt
│  │  │  ├── event_handler_list.c
│  │  │  ├── helpers.c
│  │  │  │ work_q.c
│  │  ├── include
│  │  │  ├── common
│  │  │  │  ├── event_handler_list.h
│  │  │  │  ├── helpers.h
│  │  │  │  │ work_q.h
│  │  │  ├── modules
│  │  │  │  ├── cereg.h
│  │  │  │  ├── cfun.h
│  │  │  │  ├── coneval.h
│  │  │  │  ├── cscon.h
│  │  │  │  ├── edrx.h
│  │  │  │  ├── mdmev.h
│  │  │  │  ├── ncellmeas.h
│  │  │  │  ├── periodicsearchconf.h
│  │  │  │  ├── psm.h
│  │  │  │  ├── rai.h
│  │  │  │  ├── redmob.h
│  │  │  │  ├── xfactoryreset.h
│  │  │  │  ├── xmodemsleep.h
│  │  │  │  ├── xsystemmode.h
│  │  │  │  │ xt3412.h
│  │  ├── lte_lc.c
│  │  ├── lte_lc_modem_hooks.c
│  │  ├── modules
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── cereg.c
│  │  │  ├── cfun.c
│  │  │  ├── coneval.c
│  │  │  ├── cscon.c
│  │  │  ├── edrx.c
│  │  │  ├── mdmev.c
│  │  │  ├── ncellmeas.c
│  │  │  ├── periodicsearchconf.c
│  │  │  ├── psm.c
│  │  │  ├── rai.c
│  │  │  ├── redmob.c
│  │  │  ├── xfactoryreset.c
│  │  │  ├── xmodemsleep.c
│  │  │  ├── xsystemmode.c
│  │  │  │ xt3412.c
modules
│  ├── memfault-firmware-sdk
│  │  │ Kconfig
samples
│  ├── cellular
│  │  ├── battery
│  │  │  │ prj.conf
│  │  ├── gnss
│  │  │  │ prj.conf
│  │  ├── location
│  │  │  │ prj.conf
│  │  ├── modem_shell
│  │  │  │ prj.conf
│  │  ├── nrf_cloud_multi_service
│  │  │  │ prj.conf
│  │  ├── nrf_cloud_rest_cell_location
│  │  │  │ prj.conf
│  │  ├── udp
│  │  │  │ prj.conf
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── lwm2m_client_utils
│  │  │  │  │ Kconfig
tests
│  ├── lib
│  │  ├── location
│  │  │  │ prj.conf
│  │  ├── lte_lc_api
│  │  │  │ prj.conf

Outputs:

Toolchain

Version: 9583beca34
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9583beca34_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

• ◻️ Toolchain - Skipped: existing toolchain is used
• ❌ Build twister
  • sdk-nrf test count: 320
• ❌ Integration tests
  • ❌ test-fw-nrfconnect-nrf-iot_cloud
  • ❌ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
  • ❌ test-fw-nrfconnect-nrf-iot_samples
  • ❌ test-fw-nrfconnect-nrf-iot_lwm2m
  • ❌ test-fw-nrfconnect-nrf-iot_thingy91
  • ❌ test-fw-nrfconnect-nrf-iot_mosh
  • ❌ test-fw-nrfconnect-nrf-iot_positioning
  • ⚠️ test-fw-nrfconnect-fw-update

Disabled integration tests

• • desktop52_verification
  • doc-internal
  • test_ble_nrf_config
  • test-fw-nrfconnect-apps
  • test-fw-nrfconnect-ble_mesh
  • test-fw-nrfconnect-ble_samples
  • test-fw-nrfconnect-boot
  • test-fw-nrfconnect-chip
  • test-fw-nrfconnect-fem
  • test-fw-nrfconnect-nfc
  • test-fw-nrfconnect-nrf-iot_libmodem-nrf
  • test-fw-nrfconnect-nrf-iot_nrf_provisioning
  • test-fw-nrfconnect-nrf-iot_serial_lte_modem
  • test-fw-nrfconnect-nrf_crypto
  • test-fw-nrfconnect-proprietary_esb
  • test-fw-nrfconnect-ps
  • test-fw-nrfconnect-rpc
  • test-fw-nrfconnect-rs
  • test-fw-nrfconnect-tfm
  • test-fw-nrfconnect-thread
  • test-fw-nrfconnect-zigbee
  • test-low-level
  • test-sdk-audio
  • test-sdk-dfu
  • test-sdk-find-my
  • test-sdk-mcuboot
  • test-sdk-pmic-samples
  • test-sdk-sidewalk
  • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

[NordicBuilder]

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

[trantanen]

MOSH doesn't compile with this dependency. Not sure what the intention of this is.

[MirkoCovizzi]

I was experimenting, targeting https_client sample which uses lte_net_if.