Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: mesh: remove deprecated legacy sensor API #17537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m-alperen-sener
Copy link
Contributor

  • Removing kconfig option BT_MESH_SENSOR_USE_LEGACY_SENSOR_VALUE and removing legacy sensor API.
  • Remove unit tests for legacy sensor APIs.

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. labels Sep 27, 2024
@m-alperen-sener m-alperen-sener force-pushed the remove_deprecated_legacy_sensor_api branch from f56f5fc to 8a64707 Compare September 27, 2024 14:47
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@m-alperen-sener m-alperen-sener force-pushed the remove_deprecated_legacy_sensor_api branch from 8a64707 to ee59927 Compare September 27, 2024 15:05
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 27, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 27, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: ecf7d2c28b30c156d37199f1c6857108f9041b7a

more details

sdk-nrf:

PR head: ecf7d2c28b30c156d37199f1c6857108f9041b7a
merge base: 04933aa294eb4e78d6f9959b67aca7da8aa6a6f4
target head (main): a46eda7f14f9c0f7ad79d24c362199e44197b3dd
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (42)
doc
│  ├── nrf
│  │  ├── libraries
│  │  │  ├── bluetooth_services
│  │  │  │  ├── mesh
│  │  │  │  │  ├── light_ctrl_cli.rst
│  │  │  │  │  ├── light_ctrl_srv.rst
│  │  │  │  │  ├── sensor.rst
│  │  │  │  │  ├── sensor_cli.rst
│  │  │  │  │  │ sensor_srv.rst
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
include
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── light_ctrl.h
│  │  │  ├── light_ctrl_cli.h
│  │  │  ├── light_ctrl_srv.h
│  │  │  ├── sensor.h
│  │  │  ├── sensor_cli.h
│  │  │  │ sensor_srv.h
samples
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── light_ctrl
│  │  │  │  │ prj.conf
│  │  │  ├── sensor_client
│  │  │  │  │ prj.conf
│  │  │  ├── sensor_server
│  │  │  │  │ prj.conf
subsys
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── Kconfig.sensor
│  │  │  ├── light_ctrl_cli.c
│  │  │  ├── light_ctrl_internal.h
│  │  │  ├── light_ctrl_srv.c
│  │  │  ├── sensor.c
│  │  │  ├── sensor.h
│  │  │  ├── sensor_cli.c
│  │  │  ├── sensor_srv.c
│  │  │  ├── sensor_types.c
│  │  │  ├── shell
│  │  │  │  ├── shell_ctrl_cli.c
│  │  │  │  ├── shell_sensor_cli.c
│  │  │  │  ├── shell_utils.c
│  │  │  │  │ shell_utils.h
tests
│  ├── bluetooth
│  │  ├── tester
│  │  │  ├── prj.conf
│  │  │  ├── src
│  │  │  │  ├── mmdl.c
│  │  │  │  │ model_handler.c
│  ├── subsys
│  │  ├── bluetooth
│  │  │  ├── mesh
│  │  │  │  ├── light_ctrl
│  │  │  │  │  │ CMakeLists.txt
│  │  │  │  ├── models
│  │  │  │  │  │ prj.conf
│  │  │  │  ├── sensor_subsys
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── prj.conf
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  │  │  │ testcase.yaml
│  │  │  │  ├── sensor_subsys_new
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── prj.conf
│  │  │  │  │  ├── sensor_types.ld
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: 9583beca34
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9583beca34_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 731
  • ❌ Integration tests
    • ❌ desktop52_verification
    • ❌ test-fw-nrfconnect-ble_mesh
    • ❌ test-fw-nrfconnect-ble_samples
Disabled integration tests
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

- Removing kconfig option BT_MESH_SENSOR_USE_LEGACY_SENSOR_VALUE and
removing legacy sensor API.
- Remove unit tests for legacy sensor APIs.

Signed-off-by: alperen sener <alperen.sener@nordicsemi.no>
@m-alperen-sener m-alperen-sener force-pushed the remove_deprecated_legacy_sensor_api branch from ee59927 to ecf7d2c Compare September 27, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ble mesh Label for ble mesh PRbot. Add this if PR is related to ble mesh and you need to get review. doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants