samples: dect_phy: dect_shell: mac: rach_tx: interval support #18915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 8069297418cd7e9676866dc743ecee1b82bd7e9f more detailssdk-nrf:
Github labels
List of changed files detected by CI (10)Outputs:ToolchainVersion: f51bdba1d9 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
peknis
requested changes
Nov 15, 2024
|
Is this change remarkable enough to deserve a changelog entry? |
Added a an option to send data in intervals: --interval <secs> Additionally, in addition to given data, to include also modem temperature to data in json format: --get_mdm_temp Signed-off-by: Jani Hirsimäki <jani.hirsimaki@nordicsemi.no>
jhirsi
force-pushed
the
desh_rach_tx_interval
branch
from
02a1ea1
to
8069297
Compare
@peknis , I think that existing comment in release notes covers this as well. This is an update to recently added dect mac command. |
peknis
approved these changes
Nov 15, 2024
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
tokangas
reviewed
Nov 15, 2024
| sprintf(tmp_str, "{\"data\":\"%s\",\"m_tmp\":\"%d\"", | ||
| cmd_params.tx_data_str, mdm_temperature); | ||
| } | ||
| strcat(tmp_str, "}"); |
There was a problem hiding this comment.
Is there are reason why this is in a separate strcat() instead of the sprintf() calls above?
| "Options:\n" | ||
| " -d, --data <data_str>, Data to be sent.\n" | ||
| " -p, --tx_pwr <integer>, TX power (dBm) (default 0 dBm)\n" | ||
| " -m, --tx_mcs <integer>, TX MCS (integer). Default: 0.\n" | ||
| " -t, --long_rd_id <id>, Target long rd id (default: 38).\n" | ||
| " -i, --interval <interval_secs>, Data sending interval in seconds.\n" | ||
| " Default: 0, no interval, i.e. one timer.\n" |
There was a problem hiding this comment.
Suggested change
| " Default: 0, no interval, i.e. one timer.\n" | |
| " Default: 0, data sent only once.\n" |
Comment on lines
+442
to
+443
| " -j, --get_mdm_temp, Get modem temperature to be included also in\n" | ||
| " a payload. json will be encoded.\n" |
There was a problem hiding this comment.
Suggested change
| " -j, --get_mdm_temp, Get modem temperature to be included also in\n" | |
| " a payload. json will be encoded.\n" | |
| " -j, --get_mdm_temp, Include modem temperature in the payload. The payload\n" | |
| " is encoded in JSON.\n" |
| case 'i': { | ||
| params.interval_secs = atoi(optarg); | ||
| if (params.interval_secs < 0) { | ||
| desh_error("Give decent interval (> 0)"); |
There was a problem hiding this comment.
Suggested change
| desh_error("Give decent interval (> 0)"); | |
| desh_error("The interval must be positive."); |
| ((strlen(params.tx_data_str) + DECT_PHY_MAC_RACH_TX_DATA_JSON_OVERHEAD) >= | ||
| (DECT_DATA_MAX_LEN - 1))) { | ||
| desh_error( | ||
| "Generated json data is too long to be included with modem temperature."); |
There was a problem hiding this comment.
Maybe something like this. Or at least make JSON upper case.
Suggested change
| "Generated json data is too long to be included with modem temperature."); | |
| "The given data is too long to be encoded into JSON with modem temperature."); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a an option to send data in intervals: --interval
Additionally, in addition to given data, to include also modem temperature to data in json format: --get_mdm_temp