[nrf fromlist] drivers: mspi: Add driver for Designware SSI based controllers #7424
ananglcompliance.yml
on: pull_request
Run compliance checks on patch series (PR)
2m 42s
Annotations
1 error, 1 warning, and 10 notices
|
Run compliance checks on patch series (PR)
Process completed with exit code 1.
|
|
Run compliance checks on patch series (PR):
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
- rc = mspi_dev_config(drv_config->bus, &drv_config->mspi_id,
- MSPI_DEVICE_CONFIG_ALL, &drv_config->mspi_cfg);
+ rc = mspi_dev_config(drv_config->bus, &drv_config->mspi_id, MSPI_DEVICE_CONFIG_ALL,
+ &drv_config->mspi_cfg);
File:drivers/flash/flash_mspi_nor.c
Line:55
You may want to run clang-format on this change:
-static int api_read(const struct device *dev, off_t addr, void *dest,
- size_t size)
+static int api_read(const struct device *dev, off_t addr, void *dest, size_t size)
File:drivers/flash/flash_mspi_nor.c
Line:87
You may want to run clang-format on this change:
- drv_data->xfer.cmd_length = 2;
+ drv_data->xfer.cmd_length = 2;
drv_data->xfer.addr_length = 4;
- drv_data->xfer.rx_dummy = 20;
- drv_data->packet.dir = MSPI_RX;
- drv_data->packet.cmd = SPI_NOR_OCMD_RD;
- drv_data->packet.address = addr;
- drv_data->packet.data_buf = dest;
+ drv_data->xfer.rx_dummy = 20;
+ drv_data->packet.dir = MSPI_RX;
+ drv_data->packet.cmd = SPI_NOR_OCMD_RD;
+ drv_data->packet.address = addr;
+ drv_data->packet.data_buf = dest;
drv_data->packet.num_bytes = size;
- rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id,
- &drv_data->xfer);
+ rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id, &drv_data->xfer);
File:drivers/flash/flash_mspi_nor.c
Line:116
You may want to run clang-format on this change:
- drv_data->xfer.cmd_length = 2;
+ drv_data->xfer.cmd_length = 2;
drv_data->xfer.addr_length = 4;
- drv_data->xfer.rx_dummy = 4;
- drv_data->packet.dir = MSPI_RX;
- drv_data->packet.cmd = SPI_NOR_OCMD_RDSR;
- drv_data->packet.address = 0;
- drv_data->packet.data_buf = &status_reg;
+ drv_data->xfer.rx_dummy = 4;
+ drv_data->packet.dir = MSPI_RX;
+ drv_data->packet.cmd = SPI_NOR_OCMD_RDSR;
+ drv_data->packet.address = 0;
+ drv_data->packet.data_buf = &status_reg;
drv_data->packet.num_bytes = sizeof(status_reg);
- rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id,
- &drv_data->xfer);
+ rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id, &drv_data->xfer);
File:drivers/flash/flash_mspi_nor.c
Line:145
You may want to run clang-format on this change:
-static int api_write(const struct device *dev, off_t addr, const void *src,
- size_t size)
+static int api_write(const struct device *dev, off_t addr, const void *src, size_t size)
File:drivers/flash/flash_mspi_nor.c
Line:161
You may want to run clang-format on this change:
- drv_data->xfer.cmd_length = 2;
- drv_data->xfer.tx_dummy = 0;
- drv_data->packet.dir = MSPI_TX;
+ drv_data->xfer.cmd_length = 2;
+ drv_data->xfer.tx_dummy = 0;
+ drv_data->packet.dir = MSPI_TX;
drv_data->xfer.addr_length = 0;
- drv_data->packet.cmd = SPI_NOR_OCMD_WREN;
+ drv_data->packet.cmd = SPI_NOR_OCMD_WREN;
drv_data->packet.num_bytes = 0;
- rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id,
- &drv_data->xfer);
+ rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id, &drv_data->xfer);
if (rc < 0) {
LOG_ERR("SPI_NOR_OCMD_WREN xfer failed: %d", rc);
break;
}
drv_data->xfer.addr_length = 4;
- drv_data->packet.cmd = SPI_NOR_OCMD_PAGE_PRG;
- drv_data->packet.address = addr;
- drv_data->packet.data_buf = (uint8_t *)src;
+ drv_data->packet.cmd = SPI_NOR_OCMD_PAGE_PRG;
+ drv_data->packet.address = addr;
+ drv_data->packet.data_buf = (uint8_t *)src;
drv_data->packet.num_bytes = to_write;
- rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id,
- &drv_data->xfer);
+ rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id, &drv_data->xfer);
if (rc < 0) {
LOG_ERR("SPI_NOR_OCMD_PAGE_PRG xfer failed: %d", rc);
break;
}
addr += to_write;
- src = (const uint8_t *)src + to_write;
+ src = (const uint8_t *)src + to_write;
File:drivers/flash/flash_mspi_nor.c
Line:215
You may want to run clang-format on this ch
|
|
You may want to run clang-format on this change:
drivers/flash/flash_mspi_nor.c#L55
drivers/flash/flash_mspi_nor.c:55
- rc = mspi_dev_config(drv_config->bus, &drv_config->mspi_id,
- MSPI_DEVICE_CONFIG_ALL, &drv_config->mspi_cfg);
+ rc = mspi_dev_config(drv_config->bus, &drv_config->mspi_id, MSPI_DEVICE_CONFIG_ALL,
+ &drv_config->mspi_cfg);
|
|
You may want to run clang-format on this change:
drivers/flash/flash_mspi_nor.c#L87
drivers/flash/flash_mspi_nor.c:87
-static int api_read(const struct device *dev, off_t addr, void *dest,
- size_t size)
+static int api_read(const struct device *dev, off_t addr, void *dest, size_t size)
|
|
You may want to run clang-format on this change:
drivers/flash/flash_mspi_nor.c#L116
drivers/flash/flash_mspi_nor.c:116
- drv_data->xfer.cmd_length = 2;
+ drv_data->xfer.cmd_length = 2;
drv_data->xfer.addr_length = 4;
- drv_data->xfer.rx_dummy = 20;
- drv_data->packet.dir = MSPI_RX;
- drv_data->packet.cmd = SPI_NOR_OCMD_RD;
- drv_data->packet.address = addr;
- drv_data->packet.data_buf = dest;
+ drv_data->xfer.rx_dummy = 20;
+ drv_data->packet.dir = MSPI_RX;
+ drv_data->packet.cmd = SPI_NOR_OCMD_RD;
+ drv_data->packet.address = addr;
+ drv_data->packet.data_buf = dest;
drv_data->packet.num_bytes = size;
- rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id,
- &drv_data->xfer);
+ rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id, &drv_data->xfer);
|
|
You may want to run clang-format on this change:
drivers/flash/flash_mspi_nor.c#L145
drivers/flash/flash_mspi_nor.c:145
- drv_data->xfer.cmd_length = 2;
+ drv_data->xfer.cmd_length = 2;
drv_data->xfer.addr_length = 4;
- drv_data->xfer.rx_dummy = 4;
- drv_data->packet.dir = MSPI_RX;
- drv_data->packet.cmd = SPI_NOR_OCMD_RDSR;
- drv_data->packet.address = 0;
- drv_data->packet.data_buf = &status_reg;
+ drv_data->xfer.rx_dummy = 4;
+ drv_data->packet.dir = MSPI_RX;
+ drv_data->packet.cmd = SPI_NOR_OCMD_RDSR;
+ drv_data->packet.address = 0;
+ drv_data->packet.data_buf = &status_reg;
drv_data->packet.num_bytes = sizeof(status_reg);
- rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id,
- &drv_data->xfer);
+ rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id, &drv_data->xfer);
|
|
You may want to run clang-format on this change:
drivers/flash/flash_mspi_nor.c#L161
drivers/flash/flash_mspi_nor.c:161
-static int api_write(const struct device *dev, off_t addr, const void *src,
- size_t size)
+static int api_write(const struct device *dev, off_t addr, const void *src, size_t size)
|
|
You may want to run clang-format on this change:
drivers/flash/flash_mspi_nor.c#L215
drivers/flash/flash_mspi_nor.c:215
- drv_data->xfer.cmd_length = 2;
- drv_data->xfer.tx_dummy = 0;
- drv_data->packet.dir = MSPI_TX;
+ drv_data->xfer.cmd_length = 2;
+ drv_data->xfer.tx_dummy = 0;
+ drv_data->packet.dir = MSPI_TX;
drv_data->xfer.addr_length = 0;
- drv_data->packet.cmd = SPI_NOR_OCMD_WREN;
+ drv_data->packet.cmd = SPI_NOR_OCMD_WREN;
drv_data->packet.num_bytes = 0;
- rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id,
- &drv_data->xfer);
+ rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id, &drv_data->xfer);
if (rc < 0) {
LOG_ERR("SPI_NOR_OCMD_WREN xfer failed: %d", rc);
break;
}
drv_data->xfer.addr_length = 4;
- drv_data->packet.cmd = SPI_NOR_OCMD_PAGE_PRG;
- drv_data->packet.address = addr;
- drv_data->packet.data_buf = (uint8_t *)src;
+ drv_data->packet.cmd = SPI_NOR_OCMD_PAGE_PRG;
+ drv_data->packet.address = addr;
+ drv_data->packet.data_buf = (uint8_t *)src;
drv_data->packet.num_bytes = to_write;
- rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id,
- &drv_data->xfer);
+ rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id, &drv_data->xfer);
if (rc < 0) {
LOG_ERR("SPI_NOR_OCMD_PAGE_PRG xfer failed: %d", rc);
break;
}
addr += to_write;
- src = (const uint8_t *)src + to_write;
+ src = (const uint8_t *)src + to_write;
|
|
You may want to run clang-format on this change:
drivers/flash/flash_mspi_nor.c#L262
drivers/flash/flash_mspi_nor.c:262
- drv_data->xfer.cmd_length = 2;
- drv_data->xfer.tx_dummy = 0;
- drv_data->packet.dir = MSPI_TX;
+ drv_data->xfer.cmd_length = 2;
+ drv_data->xfer.tx_dummy = 0;
+ drv_data->packet.dir = MSPI_TX;
drv_data->packet.num_bytes = 0;
drv_data->xfer.addr_length = 0;
- drv_data->packet.cmd = SPI_NOR_OCMD_WREN;
- rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id,
- &drv_data->xfer);
+ drv_data->packet.cmd = SPI_NOR_OCMD_WREN;
+ rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id, &drv_data->xfer);
|
|
You may want to run clang-format on this change:
drivers/flash/flash_mspi_nor.c#L287
drivers/flash/flash_mspi_nor.c:287
- drv_data->packet.cmd = SPI_NOR_OCMD_CE;
+ drv_data->packet.cmd = SPI_NOR_OCMD_CE;
size -= flash_size;
} else {
/* Sector erase. */
drv_data->xfer.addr_length = 4;
- drv_data->packet.cmd = SPI_NOR_OCMD_SE;
- drv_data->packet.address = addr;
+ drv_data->packet.cmd = SPI_NOR_OCMD_SE;
+ drv_data->packet.address = addr;
addr += SPI_NOR_SECTOR_SIZE;
size -= SPI_NOR_SECTOR_SIZE;
}
- rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id,
- &drv_data->xfer);
- if (rc < 0) {
- LOG_ERR("Erase command 0x%02x xfer failed: %d",
- drv_data->packet.cmd, rc);
+ rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id, &drv_data->xfer);
+ if (rc < 0) {
+ LOG_ERR("Erase command 0x%02x xfer failed: %d", drv_data->packet.cmd, rc);
|
|
You may want to run clang-format on this change:
drivers/flash/flash_mspi_nor.c#L303
drivers/flash/flash_mspi_nor.c:303
-static const
-struct flash_parameters *api_get_parameters(const struct device *dev)
+static const struct flash_parameters *api_get_parameters(const struct device *dev)
|
|
You may want to run clang-format on this change:
drivers/flash/flash_mspi_nor.c#L330
drivers/flash/flash_mspi_nor.c:330
- drv_data->xfer.cmd_length = 2;
+ drv_data->xfer.cmd_length = 2;
drv_data->xfer.addr_length = 4;
- drv_data->xfer.rx_dummy = 4;
- drv_data->packet.dir = MSPI_RX;
- drv_data->packet.cmd = JESD216_OCMD_READ_ID;
- drv_data->packet.address = 0;
- drv_data->packet.data_buf = id;
+ drv_data->xfer.rx_dummy = 4;
+ drv_data->packet.dir = MSPI_RX;
+ drv_data->packet.cmd = JESD216_OCMD_READ_ID;
+ drv_data->packet.address = 0;
+ drv_data->packet.data_buf = id;
drv_data->packet.num_bytes = JESD216_READ_ID_LEN;
- rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id,
- &drv_data->xfer);
+ rc = mspi_transceive(drv_config->bus, &drv_config->mspi_id, &drv_data->xfer);
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
compliance.xml
|
8.95 KB |
|