Skip to content

Commit

Permalink
[nrf fromtree] Bluetooth: BAP: Update log for unicast iso recv withou…
Browse files Browse the repository at this point in the history
…t endpoint

Since we always set up the ISO data path for endpoints in both
directions (due to limitations in the ISO API), we can actually
receive valid (empty) SDUs on a CIS in a direction that has not
been configured.

This is not the ideal solution, but prevents unncessary LOG_ERR.
The ideal solution is to modify the ISO API to provide the
flexibility that BAP needs w.r.t. ISO data paths, but that is
a larger change for later.

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
(cherry picked from commit 13a357b)
Signed-off-by: Alexander Svensen <alexander.svensen@nordicsemi.no>
  • Loading branch information
Thalley authored and cvinayak committed Feb 6, 2024
1 parent 6994d09 commit 96325d2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion subsys/bluetooth/audio/ascs.c
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,8 @@ static void ascs_iso_recv(struct bt_iso_chan *chan,
* host as HCI ISO data packets, which we should just ignore
*/
if ((info->flags & BT_ISO_FLAGS_VALID) != 0) {
LOG_ERR("iso %p not bound with ep", chan);
LOG_DBG("Valid ISO packet of len %zu received for iso %p not bound with ep",
net_buf_frags_len(buf), chan);
}

return;
Expand Down
3 changes: 2 additions & 1 deletion subsys/bluetooth/audio/bap_unicast_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,8 @@ static void unicast_client_ep_iso_recv(struct bt_iso_chan *chan,
* host as HCI ISO data packets, which we should just ignore
*/
if ((info->flags & BT_ISO_FLAGS_VALID) != 0) {
LOG_ERR("iso %p not bound with ep", chan);
LOG_DBG("Valid ISO packet of len %zu received for iso %p not bound with ep",
net_buf_frags_len(buf), chan);
}

return;
Expand Down

0 comments on commit 96325d2

Please sign in to comment.