modules: mbedtls: Make PSA key types user configurations #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joerchan
force-pushed
the
psa-key-types-config
branch
2 times, most recently
from
b6c9a6b
to
b5ba15e
Compare
modules/mbedtls/Kconfig.psa
Outdated
| @@ -179,7 +179,10 @@ config PSA_HAS_HASH_SUPPORT | |||
|
|
|||
| config PSA_WANT_ALG_SHA_1 | |||
| bool | |||
| prompt "PSA SHA1 support" if !PSA_PROMPTLESS | |||
| prompt "PSA SHA-1 support (unsafe)" if !PSA_PROMPTLESS | |||
There was a problem hiding this comment.
Suggested change
| prompt "PSA SHA-1 support (unsafe)" if !PSA_PROMPTLESS | |
| prompt "PSA SHA-1 support (weak)" if !PSA_PROMPTLESS |
SebastianBoe
approved these changes
Jul 21, 2023
joerchan
force-pushed
the
psa-key-types-config
branch
2 times, most recently
from
a2f6c9b
to
be71d93
Compare
fixup! [nrf noup] modules: mbedtls: add PSA configurations Use same text naming as PSA spec for RIPEMD-160 and SHA-1. Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
fixup! [nrf noup] modules: mbedtls: add PSA configurations Add help text for for unsafe PSA algorithms. These should not be used for security. Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
fixup! [nrf noup] modules: mbedtls: add PSA configurations Make the PSA key type configurations be user configurations instead of implictly enabled based on other configurations. While AES is the most likely to be used in this case the user can choose different block ciphers for block cipher modes, and others stream ciphers also exists. This also allows applications to enable key generation without any algorithms for ECC and RSA keys. Also add the full key types configurations, even though not all may be supported. Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
joerchan
force-pushed
the
psa-key-types-config
branch
from
be71d93
to
6cd238e
Compare
mswarowsky
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the PSA key type configurations be user configurations instead
of implictly enabled based on other configurations.
While AES is the most likely to be used in this case the user can
choose different block ciphers for block cipher modes, and others
stream ciphers also exists.
This also allows applications to enable key generation without any
algorithms for ECC and RSA keys.
Also add the full key types configurations, even though not all may be
supported.
Add help text for for unsafe PSA algorithms. These should not be used
for security.
Use same text naming as PSA spec for RIPEMD-160 and SHA-1.