[nrf noup] settings: nvs: use dedicated lookup cache hash function #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylwesterKonczyk
approved these changes
Aug 10, 2023
LuDuda
approved these changes
Aug 16, 2023
|
@Damian-Nordic what about to remove DNM? |
I'm OK with that but maybe we should upstream this first? |
Damian-Nordic
force-pushed
the
nvs-settings-cache
branch
from
645bb7a
to
7b3e64b
Compare
Damian-Nordic
changed the title
|
FYI, removed DNM but only the second commit is exclusive for this PR. The first one is already upstreamed and a part of the current upmerge. |
mariuszpos
approved these changes
Sep 26, 2023
Damian-Nordic
force-pushed
the
nvs-settings-cache
branch
2 times, most recently
from
ffb383a
to
f2ecbc0
Compare
carlescufi
requested review from
rlubos,
glarsennordic and
jukkar
as code owners
Damian-Nordic
force-pushed
the
nvs-settings-cache
branch
3 times, most recently
from
af5ba19
to
a2131bb
Compare
Introduce NVS_LOOKUP_CACHE_FOR_SETTINGS Kconfig option that enables a dedicated hash function for the NVS lookup cache that takes advantage of the NVS ID allocation scheme used by the NVS settings backend. As such, this option should only be used if an application uses NVS via the settings layer. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Damian-Nordic
force-pushed
the
nvs-settings-cache
branch
from
a2131bb
to
6f7788a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
NVS_LOOKUP_CACHE_FOR_SETTINGSKconfig option that enables a dedicated hash function for the NVS lookup cache that takes advantage of the NVS ID allocation scheme used by the NVS settings backend. As such, this option should only be used if an application uses NVS via the settings layer.The commit is a
nouppatch because the original change seems not generic enough to be accepted by the Zephyr community: zephyrproject-rtos/zephyr#61619.