[nrf fromtree] ipc: Drain pending work items before deregistering endpoint #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jori-nordic
force-pushed
the
cherry-pick-68468
branch
from
f7ec2ec
to
bda92d5
Compare
jori-nordic
changed the title
|
This has been observed by one of our customers: NCSIDB-1192 |
hermabe
approved these changes
Feb 9, 2024
theob-pro
approved these changes
Feb 9, 2024
jori-nordic
force-pushed
the
cherry-pick-68468
branch
from
bda92d5
to
9b73722
Compare
…point The work item will attempt to dereference pointers that have been nulled by the backend. To avoid that, wait until all items currently on the queue have been processed. The symptom is a busfault on ARM, and is "fixed" by adding a `k_msleep(1)` right before `ipc_service_deregister_endpoint()`. This will in effect do the same thing as this patch, and allow the scheduler to run the work item on the ipc workqueue. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no> (cherry picked from commit f24a01e)
jori-nordic
force-pushed
the
cherry-pick-68468
branch
from
9b73722
to
77c2b20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…point
The work item will attempt to dereference pointers that have been nulled by the backend.
To avoid that, wait until all items currently on the queue have been processed.
The symptom is a busfault on ARM, and is "fixed" by adding a
k_msleep(1)right beforeipc_service_deregister_endpoint(). This will in effect do the same thing as this patch, and allow the scheduler to run the work item on the ipc workqueue.Signed-off-by: Jonathan Rico jonathan.rico@nordicsemi.no
(cherry picked from commit f24a01e)