[nrf fromlist] tests: drivers: timer: grtc: Fix GRTC test #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkondraciuk
requested review from
nordic-krch,
nika-nordic,
masz-nordic,
katgiadla,
ppryga-nordic and
magp-nordic
nika-nordic
approved these changes
Apr 26, 2024
adamkondraciuk
force-pushed
the
grtc_fix_tests
branch
3 times, most recently
from
c40933d
to
4984ccd
Compare
adamkondraciuk
force-pushed
the
grtc_fix_tests
branch
from
4984ccd
to
f2cf9ff
Compare
The `z_nrf_grtc_timer_get_ticks()` function converts system ticks to GRTC ticks. It gets the current system tick to calculate an absolute GRTC value. The same does the test function to provide an argument to be converted. If the system tick occurs between those `sys_clock_tick_get()` calls the `z_nrf_grtc_timer_get_ticks()` will take into account the newer tick while the test estimate bases on the old tick value. Due to that the maximum result error is 1 system tick minus 1 GRTC tick which equals (`CYC_PER_TICK` - 1) for GRTC ticks. Upstream PR: zephyrproject-rtos/zephyr#71688 Signed-off-by: Adam Kondraciuk <adam.kondraciuk@nordicsemi.no>
adamkondraciuk
force-pushed
the
grtc_fix_tests
branch
from
f2cf9ff
to
c351761
Compare
nika-nordic
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
z_nrf_grtc_timer_get_ticks()function converts system ticks to GRTC ticks. It gets the current system tick to calculate an absolute GRTC value. The same does the test function to provide an argument to be converted. If the system tick occurs between thosesys_clock_tick_get()calls thez_nrf_grtc_timer_get_ticks()will take into account the newer tick while the test estimate bases on the old tick value. Due to that the maximum result error is 1 system tick minus 1 GRTC tick which equals (CYC_PER_TICK- 1) for GRTC ticks.Upstream PR: zephyrproject-rtos/zephyr#71688