Allow disabling the nRF5340 network CPU by protocol drivers #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jciupis
force-pushed
the
pr/fix-bt-enabling-disabling-cherrypick
branch
from
4dc3686
to
2cf282b
Compare
ktaborowski
approved these changes
May 7, 2024
laxiLang
approved these changes
May 7, 2024
ankuns
approved these changes
May 7, 2024
There was a problem hiding this comment.
I think that when we have so cool module like nrf53_cpunet_mgmt there should be no code that controls the cpunet directly by nrf_reset_network_force_off. Users willing to use the nrf53 cpunet services should call nrf53_cpunet_enable(true) and when they do not need it anymore call nrf53_cpunet_enable(false). These calls should be indirect from hci_init and now in nrf_802154_spinel_backedn_init and who-knows-where-else. No board-specific code should then attempt to enable the cpunet, because what's the purpose? Just to have it enabled?
But fully moving to the new paradigm is a different (I suspect quite a big) task than just ad-hoc fixing to make things work for now.
added 2 commits
May 9, 2024 08:48
…2.15.4 init The network CPU must be requested explicitly by the 802.15.4 driver for the sharing mechanism to work correctly. Upstream PR: zephyrproject-rtos/zephyr#72412 Signed-off-by: Jędrzej Ciupis <jedrzej.ciupis@nordicsemi.no>
Board initialization code should not use the network CPU management. It acts as a permanent request for the network CPU, which causes its users to be unable to turn it off. Instead, let the board initialization code control the network CPU directly. It sets initial state of the network core but does not have any impact on sharing the network CPU as a resource between its users. Upstream PR: zephyrproject-rtos/zephyr#72412 Signed-off-by: Jędrzej Ciupis <jedrzej.ciupis@nordicsemi.no>
jciupis
force-pushed
the
pr/fix-bt-enabling-disabling-cherrypick
branch
from
2cf282b
to
ecc593c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.