soc: nordic: nrf54h: disable IRQ before PM config #2258
Merged
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkondraciuk
requested review from
karstenkoenig,
hubertmis and
ppryga-nordic
adamkondraciuk
force-pushed
the
disable-irq-before-all-PM-states-config
branch
2 times, most recently
from
061826f
to
0007b69
Compare
adamkondraciuk
force-pushed
the
disable-irq-before-all-PM-states-config
branch
from
0007b69
to
8447187
Compare
karstenkoenig
approved these changes
Nov 13, 2024
| @@ -85,14 +85,19 @@ SECTION_FUNC(TEXT, arch_pm_s2ram_suspend) | |||
| * not successful (in r0 the return value). | |||
| */ | |||
|
|
|||
| /* Move return value of system_off to callee-saved register. */ | |||
| mov r4, r0 | |||
There was a problem hiding this comment.
nice job picking that fix up
adamkondraciuk
force-pushed
the
disable-irq-before-all-PM-states-config
branch
from
8447187
to
e0868d9
Compare
… of s2ram_suspend The return value of the system_off call is overwritten by the the call to pm_s2ram_mark_check_and_clear. As arch_pm_s2ram_suspend needs to specify why system_off failed, we need to make sure the rv of system_off is moved to a safe register before calling pm_s2ram_mark_check_and_clear and moved to r0 als rv of arch_pm_s2ram_suspend when the suspend call exits. Upstream PR #: 80642 Signed-off-by: Hessel van der Molen <hvandermolen@dexels.com>
adamkondraciuk
force-pushed
the
disable-irq-before-all-PM-states-config
branch
from
e0868d9
to
7b04326
Compare
IRQs must be disabled before starting any procedures to prepare for low-power states. Upstream PR #: 79067 Signed-off-by: Adam Kondraciuk <adam.kondraciuk@nordicsemi.no>
adamkondraciuk
force-pushed
the
disable-irq-before-all-PM-states-config
branch
from
7b04326
to
50d2a72
Compare
adamkondraciuk
added
backport v3.7.99-ncs1-branch
ns-tolu
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRQs must be disabled before starting any procedures to prepare for low-power states.