Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: tls_configurations: adjust Kconfig in overlay-ec #2374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

frkv
Copy link
Contributor

@frkv frkv commented Dec 13, 2024

CONFIG_PSA_WANT_KEY_TYPE_ECC_KEY_PAIR_BASIC is promptless so it cannot be selected. Moreover it's also automatically enabled by CONFIG_PSA_WANT_KEY_TYPE_ECC_KEY_PAIR_GENERATE in the same overlay file so there would be no need to explicitly enable it.

As for the IMPORT, EXPORT, DERIVE they are needed for the TLS connection to work properly. Previously it was working because at least IMPORT and EXPORT are internally enabled by Mbed TLS at build time. So here we are basically doing the same enablements with Kconfigs in clear.

CONFIG_PSA_WANT_KEY_TYPE_ECC_KEY_PAIR_BASIC is promptless so it cannot
be selected. Moreover it's also automatically enabled by
CONFIG_PSA_WANT_KEY_TYPE_ECC_KEY_PAIR_GENERATE in the same overlay file
so there would be no need to explicitly enable it.

As for the IMPORT, EXPORT, DERIVE they are needed for the TLS connection
to work properly. Previously it was working because at least IMPORT and
EXPORT are internally enabled by Mbed TLS at build time. So here we
are basically doing the same enablements with Kconfigs in clear.

Upstream PR #: 82862

Signed-off-by: Valerio Setti <vsetti@baylibre.com>
Signed-off-by: Frank Audun Kvamtrø <frank.kvamtro@nordicsemi.no>
(cherry picked from commit 85b07784ff9658ee1ecd3a4a2f09550839ad17d6)
@shanthanordic
Copy link

Is this blocker for NCS 2.9.0 release @barsok or @frkv

@shanthanordic shanthanordic removed this from the ncs-2.9.0 milestone Dec 16, 2024
@shanthanordic
Copy link

Cleared milestone

@frkv
Copy link
Contributor Author

frkv commented Dec 17, 2024

Delayed to after the release. This will be picked up by the next upmerge (zephyrproject-rtos/zephyr#82862 which had the fromlist is now merged into zephyr main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v3.7.99-ncs2-branch Relates to NCS v2.9-branch bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants