Added suit-generator payload_extract command #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahasztag
requested review from
tomchy,
SylwesterKonczyk,
jnsgsr,
robertstypa,
adsz-nordic and
kszromek-nordic
tomchy
reviewed
Oct 18, 2024
| + "If not provided, the payload will not be stored to a file.") | ||
|
|
||
| cmd_payload_extract_arg_parser.add_argument( | ||
| "--payload-replace-name", |
There was a problem hiding this comment.
should not that be path not name?
I find it difficult to understand this arg description.
There was a problem hiding this comment.
You're absolutely right, should be path, changed this
|
pytest coverage results
Note: This message is automatically posted and updated by the CI (latest/test-sdk-dfu/master/204) |
adsz-nordic
approved these changes
Oct 21, 2024
robertstypa
requested changes
Oct 21, 2024
| :param payload_replace_name: name of the integrated payload to replace the extracted payload with. | ||
| None if the payload should be removed from the envelope. | ||
| """ | ||
| envelope = None |
There was a problem hiding this comment.
The envelope value is immediately assigned in line 56 as envelope = cbor2.load(fh), so the initial assignment is redundant and could be removed
| envelope = cbor2.load(fh) | ||
| extracted_payload = envelope.value.pop(payload_name, None) | ||
|
|
||
| if extracted_payload == None: |
There was a problem hiding this comment.
Suggested change
| if extracted_payload == None: | |
| if extracted_payload is None: |
| if extracted_payload == None: | ||
| log.log(logging.ERROR, 'Payload "%s" not found in envelope', payload_name) | ||
|
|
||
| if payload_replace_name != None: |
There was a problem hiding this comment.
Suggested change
| if payload_replace_name != None: | |
| if payload_replace_name is not None: |
|
|
||
| with open(output_envelope, "wb") as fh: | ||
| cbor2.dump(envelope, fh) | ||
| if output_payload_file != None: |
There was a problem hiding this comment.
Suggested change
| if output_payload_file != None: | |
| if output_payload_file is not None: |
ahasztag
force-pushed
the
payload_remove_from_envelope
branch
2 times, most recently
from
52d1ead
to
82b6cce
Compare
robertstypa
approved these changes
Oct 23, 2024
SylwesterKonczyk
approved these changes
Oct 24, 2024
The payload allows for extracting/removing/replacing integrated payloads in the envelope. Ref: NCSDK-29708 Signed-off-by: Artur Hadasz <artur.hadasz@nordicsemi.no>
ahasztag
force-pushed
the
payload_remove_from_envelope
branch
from
82b6cce
to
44ee5bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The payload allows for extracting/removing/replacing integrated payloads in the envelope.
Ref: NCSDK-29708