Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: camera control float encoding #161

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

Julusian
Copy link
Member

About the Contributor

This pull request is posted on behalf of the myself

Type of Contribution

This is a: Bug fix

Current Behavior

Camera control float encoding is done incorrectly, as indicated in the code that it was not confirmed.

New Behavior

The values are encoded/decoded correctly.

Testing Instructions

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5359756) 86.11% compared to head (255ecf2) 84.73%.

Files Patch % Lines
src/commands/CameraControlCommand.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   86.11%   84.73%   -1.38%     
==========================================
  Files         182      182              
  Lines        5892     5891       -1     
  Branches      973      931      -42     
==========================================
- Hits         5074     4992      -82     
- Misses        794      875      +81     
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian force-pushed the fix/camera-control-float-encoding branch from c17fb33 to 1fc093a Compare February 7, 2024 23:25
@Julusian Julusian marked this pull request as ready for review February 7, 2024 23:43
@Julusian Julusian merged commit 37e4fec into master Feb 7, 2024
14 checks passed
@Julusian Julusian deleted the fix/camera-control-float-encoding branch February 7, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants