Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Diff Different between (SOFIE-3004) #1162

Closed
jstarpl opened this issue Mar 4, 2024 · 1 comment · Fixed by #1163
Closed

Bug Report: Diff Different between (SOFIE-3004) #1162

jstarpl opened this issue Mar 4, 2024 · 1 comment · Fixed by #1163
Labels
🐛bug Something isn't working

Comments

@jstarpl
Copy link
Member

jstarpl commented Mar 4, 2024

About me

This Bug report is posted on behalf of NRK

Observed Behavior

The Diff in the Presenters' Screen and Rundown View is different

Expected Behavior

The Diff in the Presenters' Screen and Rundown View is the same

Version

Sofie Core 1.50.0

Severity / Impact

  • This is a blocker, we need this to be consistent in order for deployment of 1.50 to go ahead at NRK

Level of Involvement

  • We will be contributing a fix for this, we want to raise awareness of the problem and make sure that the community is on board with the solution
@jstarpl jstarpl added the 🐛bug Something isn't working label Mar 4, 2024
@jstarpl
Copy link
Member Author

jstarpl commented Mar 4, 2024

So far, we've been able to figure out that the problem is with the Part expectedDuration calculation algorithm contributed by EVS: #890 With that change, all Part's expectedDurations depend on their Piece durations. Because calculating the Diff requires knowing all Part's expectedDurations, that means that in order to calculate the Diff, one needs to have all the Pieces for a Playlist loaded. The GUI trims down the amount of data it needs in local cache ("minimongo") in order to maximize performance, and as such, will only have some Pieces loaded at any given time. The Presenters' screen for example will only have the Pieces for the current and next Part loaded.

Our proposal, so that at least the Diff counters are consistent across different views, is to remove this change and not to consider Pieces prerolls for calculating Parts' expectedDuration, and make this inaccuracy (in real-life scenarios summing up to a small difference) a known issue.

Eventually, we would like to resolve this new known issue by moving the Part expectedDuration calculation to the server side.

@jstarpl jstarpl changed the title Bug Report: Diff Different between Bug Report: Diff Different between (SOFIE-3004) Mar 4, 2024
@jstarpl jstarpl closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working
Projects
None yet
1 participant