Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: objID strings are incorrectly converted to number #92

Closed
PeterC89 opened this issue Feb 1, 2024 · 3 comments
Closed

Bug Report: objID strings are incorrectly converted to number #92

PeterC89 opened this issue Feb 1, 2024 · 3 comments
Labels
bug Something isn't working help wanted Noone is actively working on this, contributions are welcome

Comments

@PeterC89
Copy link
Contributor

PeterC89 commented Feb 1, 2024

About me

This bug report is posted on behalf of the BBC

Observed Behavior

When ingesting a rundown with MOS objID's that look like numbers sofie-mos-connection incorrectly converts them to a number type.
E.G:
100.543210 becomes 100.54321

I'm guessing that this is caused by the nativeType: true option for the parser, I'm not sure what impact changing it would have...

const object = xmlParser(messageString, { compact: false, trim: true, nativeType: true })

Expected Behavior

Data from a MOS device should remain of a valid type.

Version

release51

Severity / Impact

This is a significant blocker for us as our clip objIDs are numeric as above.
A workaround has been implemented so this is less urgent but still an issue.

@jesperstarkar jesperstarkar added Contributions from BBC Contributions sponsored by BBC (bbc.co.uk) and removed Contributions from BBC Contributions sponsored by BBC (bbc.co.uk) labels Feb 1, 2024
@jstarpl jstarpl added the bug Something isn't working label Feb 1, 2024
nytamin added a commit that referenced this issue Feb 2, 2024
@nytamin
Copy link
Contributor

nytamin commented Mar 1, 2024

Thank you for this bug report!
We've had a little discussion on this in the Sofie team and we agree that this is an issue in the mos-connection library.
We're not actively looking into this issue at the moment, as we haven't experienced the issues ourselves at NRK.

However, we'd welcome any PR to fix this issue and would happily coordinate or collaborate in making a fix.

@nytamin nytamin added the help wanted Noone is actively working on this, contributions are welcome label Mar 1, 2024
@olzzon
Copy link
Contributor

olzzon commented May 6, 2024

PR has been made for this fix:
#101

@nytamin
Copy link
Contributor

nytamin commented Aug 27, 2024

This should now be resolved as of version v4.2.0-alpha.1, please reopen this if any issues persists,

@nytamin nytamin closed this as completed Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Noone is actively working on this, contributions are welcome
Projects
None yet
Development

No branches or pull requests

5 participants