WIP: objId was parsed as a number, and thus removed e.g. 00 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've finally come around to start working on a "big rehaul" of the parsing of incoming data, in PR #103. That should address this issue as well, so we could close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This PR was made on behalf of BBC
Type of Contribution
Bug Fix for
#92
Current Behavior
If ObjID was a string that could be converted to a number (e.g. 00123.45600) all 00 around it would be removed.
New Behavior
In xml2Js there's now a Set called
forcedStringObjectwhere all object name in it will be forced to be converted as a string.Testing Instructions
Create an obj with objID as a number, and ingest.
Helper Tests has also been updated for this.
Status