Skip to content

Commit

Permalink
Use atomic integer instead of synchronized locking for counting scans…
Browse files Browse the repository at this point in the history
… in mapping process
  • Loading branch information
nathanielsherry committed Mar 12, 2024
1 parent ca5e165 commit 45103a7
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import java.util.Arrays;
import java.util.Collection;
import java.util.Optional;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.function.Function;
import java.util.function.Predicate;
import java.util.function.Supplier;
Expand All @@ -21,7 +22,7 @@ public class StreamExecutor<T> extends EventfulEnum<TaskMonitor.Event> implement
private StreamExecutor<?> next;
private boolean parallel = true;

private int count = 0;
private AtomicInteger count = new AtomicInteger();
private int size = -1;
private int interval = 100;
Optional<T> result = Optional.empty();
Expand Down Expand Up @@ -50,9 +51,8 @@ public void setParallel(boolean parallel) {
}

@Override
public synchronized boolean test(Object t) {
count++;
if (count % interval == 0) {
public boolean test(Object t) {
if (count.incrementAndGet() % interval == 0) {
updateListeners(Event.PROGRESS);
}
return state == State.RUNNING;
Expand Down Expand Up @@ -101,7 +101,7 @@ public State getState() {

@Override
public int getCount() {
return count;
return count.get();
}

@Override
Expand Down
5 changes: 4 additions & 1 deletion LibPeakaboo/src/main/java/org/peakaboo/mapping/Mapping.java
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,10 @@ public static StreamExecutor<RawMapSet> mapTask(
}
RawMapSet maps = new RawMapSet(transitionSeries, mapsize, !noncontiguous);

StreamExecutor<RawMapSet> streamer = new StreamExecutor<>("Applying Filters & Fittings");
int count = dataset.getScanData().scanCount();
int interval = (int)Math.max(10, Math.ceil(count / 100f));

StreamExecutor<RawMapSet> streamer = new StreamExecutor<>("Applying Filters & Fittings", interval);
streamer.setTask(new Range(0, dataset.getScanData().scanCount()), stream -> {

long t1 = System.currentTimeMillis();
Expand Down

0 comments on commit 45103a7

Please sign in to comment.