Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test_dataset_search_returns_valid_results integration test #294

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix test_dataset_search_returns_valid_results integration test #294

merged 1 commit into from
Sep 12, 2023

Conversation

jrbourbeau
Copy link
Collaborator

tests/integration/test_api.py::test_dataset_search_returns_valid_results is failing on main with (e.g. see this CI build):

FAILED tests/integration/test_api.py::test_dataset_search_returns_valid_results[kwargs2] - IndexError: list index out of range

Changing the daac fixes the issue locally for me

@github-actions
Copy link

Binder 👈 Launch a binder notebook on this branch for commit 3505185

I will automatically update this comment whenever this PR is modified

@betolink betolink self-requested a review September 12, 2023 00:20
betolink
betolink approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@betolink betolink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this until we have a better plan to test all the DAACs in a reproducible way.

@betolink betolink merged commit 4717c82 into nsidc:main Sep 12, 2023
6 checks passed
@jrbourbeau jrbourbeau deleted the int-test-fixup branch September 12, 2023 02:03
@danielfromearth danielfromearth mentioned this pull request Jul 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betolink betolink betolink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrbourbeau @betolink