Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python-dateutil as a direct dependency #397

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Add python-dateutil as a direct dependency #397

merged 1 commit into from
Dec 5, 2023

Conversation

jrbourbeau
Copy link
Collaborator

Closes #392

cc @mfisher87

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Binder 👈 Launch a binder notebook on this branch for commit f8cafef

I will automatically update this comment whenever this PR is modified

@jrbourbeau jrbourbeau mentioned this pull request Dec 5, 2023
Closed
MattF-NSIDC
MattF-NSIDC approved these changes Dec 5, 2023
View reviewed changes
Copy link

@MattF-NSIDC MattF-NSIDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

When we do the release, we need to also add this dependency to meta.yaml of the conda-forge/earthdata-feedstock. I'll record an issue over there.

@MattF-NSIDC MattF-NSIDC mentioned this pull request Dec 5, 2023
Closed
@jrbourbeau jrbourbeau merged commit 17beff1 into nsidc:main Dec 5, 2023
7 checks passed
@jrbourbeau jrbourbeau deleted the python-dateutil branch December 5, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattF-NSIDC MattF-NSIDC MattF-NSIDC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make dependency on python-dateutil explicit
2 participants
@jrbourbeau @MattF-NSIDC