Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update function list in init #461

Merged
merged 4 commits into from
May 12, 2024
Merged

update function list in init #461

merged 4 commits into from
May 12, 2024

Conversation

JessicaS11
Copy link
Collaborator

@JessicaS11 JessicaS11 commented Feb 19, 2024

When working on #424, I noticed a few of the newer api functions weren't being imported because they hadn't been added to the list in __init__.py. I update the list and added comments of which modules they're from for clarity. I'm wondering what the incentive for lines 5-17 is (versus from .api import *, with the acknowledgement that *isn't best practice - so perhaps there's a better solution) so two manual lists of the functions in .api don't need to be maintained.

This work is currently included in #424, but I figured separating it out would be clearer.


📚 Documentation preview 📚: https://earthaccess--461.org.readthedocs.build/en/461/

earthaccess/__init__.py Outdated Show resolved Hide resolved
earthaccess/__init__.py Show resolved Hide resolved
@chuckwondo
Copy link
Collaborator

@JessicaS11, do you have time to address @jhkennedy's comments so we can approve and merge your contribution?

@JessicaS11
Copy link
Collaborator Author

@chuckwondo Thanks for the ping - it looks like my updates and your message crossed paths. This should be all set. I also just checked against the current api.py and the list still looks complete.

@chuckwondo chuckwondo merged commit c04199a into main May 12, 2024
17 checks passed
@mfisher87 mfisher87 deleted the init-list branch May 12, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants