Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote the pip install specification in development docs #814

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

mfisher87
Copy link
Collaborator

@mfisher87 mfisher87 commented Sep 17, 2024

Woops! Excellent catch @itcarroll


📚 Documentation preview 📚: https://earthaccess--814.org.readthedocs.build/en/814/

Copy link
Collaborator

@chuckwondo chuckwondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes are unnecessary

@chuckwondo
Copy link
Collaborator

I suggest closing this PR, as the quotes are unnecessary.

@itcarroll
Copy link
Collaborator

itcarroll commented Sep 17, 2024

I think they are necessary in macOS zsh.

corrected

% pip install -e .[dev,test,docs]
zsh: no matches found: .[dev,test,docs]

@jhkennedy
Copy link
Collaborator

Yes, [ and ] are char-set wildcards in zsh and I can confirm I hit this issue as well. Zsh is the default shell on macs now, so we should be zsh safe in our docs.

@chuckwondo
Copy link
Collaborator

Sorry, I'm still on bash, so didn't realize this is a problem for zsh.

@mfisher87
Copy link
Collaborator Author

mfisher87 commented Sep 17, 2024

🚀

Zsh is the default shell on macs now, so we should be zsh safe in our docs.

💯

Sorry, I'm still on bash, so didn't realize this is a problem for zsh.

Same 😆 The frustrating part for me is I've learned this lesson about zsh the hard way too many times now.

@mfisher87 mfisher87 merged commit ac8114c into main Sep 17, 2024
13 checks passed
@mfisher87 mfisher87 deleted the fix-contributing-setup-command branch September 17, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants