restore AbstractBaseClass inheritance #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
==========================================
+ Coverage 73.88% 73.90% +0.01%
==========================================
Files 31 31
Lines 2003 2004 +1
==========================================
+ Hits 1480 1481 +1
Misses 523 523 ☔ View full report in Codecov by Sentry. |
mfisher87
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A hackday quick fix with @nikki-t and @mfisher87 to undo the bad effects of #620. Conversation continues about the original bug report (#610).
What this PR does:
fsspec.spec.AbstractBufferedFileparent class (back) toEarthAccessFiletest_earthaccess_file_getattrtest as expected fail because we re-introduce method resolution surprise onEarthAccessFile#610.