-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update releasing docs from run-through with Nikki #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Nikki Tebaldi <17799906+nikki-t@users.noreply.github.com>
This isn't rendering nicely in Mkdocs. Needs fix! |
nikki-t
previously approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments on some suggestion but I think the updated documentation on the release process look great!
mfisher87
commented
Oct 2, 2024
Switch GitHub-style notes to Mkdocs admonitions
Fixed up the formatting in Mkdocs! 5b84afc |
Looks great! |
nikki-t
approved these changes
Oct 2, 2024
Thanks, @nikki-t ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered an issue: #833 but chose to skip over that problem by giving Nikki temporary (already-revoked) privileges to bypass branch protection. The doc is updated assuming that one can actually push directly to
main
, but I think we should switch to doing all releases in PRs and update the doc accordingly. What does everyone think?📚 Documentation preview 📚: https://earthaccess--834.org.readthedocs.build/en/834/