Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.9; eliminate duplicate run of test-mindeps CI #876

Merged
merged 7 commits into from
Nov 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
python-version: ["3.10", "3.11", "3.12", "3.13"]
fail-fast: false

steps:
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/test-mindeps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Unit test minimum dependencies

on:
push:
branches:
- main
pull_request:
workflow_dispatch:

Expand Down Expand Up @@ -29,7 +31,7 @@ jobs:
- name: Setup nox
uses: wntrblm/nox@2024.10.09
with:
python-versions: 3.9
python-versions: "3.10"

- name: Test
run: nox -s test-min-deps -- --verbose --cov=earthaccess --cov-report=term-missing --capture=no --tb=native --log-cli-level=INFO
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
python-version: ["3.10", "3.11", "3.12", "3.13"]
fail-fast: false

steps:
Expand Down
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ and this project uses [Semantic Versioning](https://semver.org/spec/v2.0.0.html)

- The `scripts/integration-test.sh` script has been removed in favor of the `integration-tests` nox session.
([#872](https://github.com/nsidc/earthaccess/issues/872)) ([@jhkennedy](https://github.com/jhkennedy))
- Python 3.9 is no longer supported.
([#876](https://github.com/nsidc/earthaccess/pull/876))
([@mfisher87](https://github.com/mfisher87))

### Fixed

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Visit [our quick start guide](https://earthaccess.readthedocs.io/en/latest/quick

## Compatibility

The _minimum_ supported Python version is **3.9**.
The _minimum_ supported Python version is **3.10**.


## How to Contribute to `earthaccess`
Expand Down
2 changes: 1 addition & 1 deletion noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def tests(session: nox.Session) -> None:
)


@nox.session(name="test-min-deps", python="3.9", venv_backend="uv")
@nox.session(name="test-min-deps", python="3.10", venv_backend="uv")
def test_min_deps(session: nox.Session) -> None:
"""Run the unit tests using the lowest compatible version of all direct dependencies."""
session.install("--resolution", "lowest-direct", "--editable", ".[test]")
Expand Down
12 changes: 5 additions & 7 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,16 @@ classifiers = [
"Operating System :: Microsoft :: Windows",
"Operating System :: MacOS",
"Operating System :: POSIX :: Linux",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Topic :: Software Development :: Libraries",
"Topic :: Software Development",
"License :: OSI Approved :: MIT License",
]

requires-python = ">=3.9"
requires-python = ">=3.10"

dependencies = [
"python-cmr >=0.10.0",
Expand All @@ -57,14 +57,12 @@ Changelog = "https://github.com/nsidc/earthaccess/blob/main/CHANGELOG.md"

[project.optional-dependencies]
kerchunk = [
"numpy >=1.26.4",
"kerchunk",
"dask",
"h5py >=3.0",
"h5py >=3.6.0",
"h5netcdf",
"xarray",
# kerchunk requires numpy, but numpy >=1.26.0 is required for Python 3.12
"numpy >=1.24.0; python_version < '3.12'",
"numpy >=1.26.0; python_version >= '3.12'",
]
dev = [
"bump-my-version >=0.10.0",
Expand Down Expand Up @@ -125,7 +123,7 @@ docs = [
filterwarnings = ["error::UserWarning"]

[tool.mypy]
python_version = "3.9"
python_version = "3.10"
files = ["earthaccess", "tests"]
mypy_path = ["earthaccess", "tests", "stubs"]
disallow_untyped_defs = true
Expand Down
2,859 changes: 1,356 additions & 1,503 deletions uv.lock

Large diffs are not rendered by default.

Loading