Asiaq nunagis places layers #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lot of overlap between our existing place names database from Asiaq and these
layers. Of course, these layers do not have english translations/explanations.
We need to decide if we want to keep the original place names database
around ("Towns and settlements" is derived from it). It includes way more than
just towns/settlements. It has place names for various outher landmarks (e.g.,
islands, lakes, etc). Maybe we keep that layer and the cities & towns from
NunaGIS separately? Or just get rid of the Asiaq place names database layers
altogether?
This was referenced Jun 21, 2023
Merged
trey-stafford
commented
Jun 21, 2023
These are now covered by the "Cities" and "Settlement" layers.
Reflects new layer name. The "places.py" file also includes data from asiaq.
reflects layers configured in file
We are excluding towns and settlements, for which these notes were about, from the POI layer
MattF-NSIDC
approved these changes
Jul 19, 2023
|
We haven't received any comments about the "town and settlements" name, so I think we can set aside needing to change that at this point. Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New "Places/Towns" and "Places/Settlements" layers from NunaGIS/Asiaq. This replaces our existing "Places/Towns and Settlements" layer.
I have also renamed the "Places/Place names database" layer to "Places/Points of interest" (and added some SQL to exclude towns and settlements). We do not have another source for these data (contains point data indicating e.g., islands, lakes, etc). Additionally, they include the translations we had done for that dataset.
To consider:
Checklist
If an item on this list is done or not needed, simply check it with
[x].inv config.export > qgreenland/config/cfg-lock.json)bumpversion (major|minor|patch|prerelease|build)