Replace IBCAO with GEBCO grid (bathymetry raster dataset) #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GEBCO grid is global, so we can cover all of the QGreenland background this way (IBCAO only covers a relatively small area around Greenland) This layer is actually smaller than IBCAO (it has an `int` dtype), even at the same resolution!
The GEBCO grid clipped to our background boundary has a lower minimum than the IBCAO grid. This sets the minimum lower (values lower than the orignally set min were transparent)
|
Favoring this PR over #582 |
5 tasks
trey-stafford
changed the title
MattF-NSIDC
suggested changes
Jun 26, 2023
qgreenland/config/layers/Oceanography/Bathymetry/bathymetric_chart.py
Outdated
Show resolved
Hide resolved
…hart.py Co-authored-by: Matt Fisher <matt.fisher@nsidc.org>
5 tasks
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the International Bathymetric Chart of the Arctic Ocean (IBCAO) dataset with General Bathymetric Chart of the Oceans (GEBCO) Grid 2023.
The GEBCO grid includes the IBCAO grid. The advantage here is that the GEBCO grid covers the entire world, so we can clip it to our background boundary like our other oceanography related layers (e.g., for the same reason as: #538)
Increasing the coverage with GEBCO actually results in a smaller layer size on disk! About 617M on disk vs the IBCAO layer's 708M. IBCAO had data as floating point values while GEBCO uses integers.
Checklist
If an item on this list is done or not needed, simply check it with
[x].inv config.export > qgreenland/config/cfg-lock.json)bumpversion (major|minor|patch|prerelease|build)