Update bathymetry contours layer #586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is enough reason for me to say we should ditch the contour layer! |
trey-stafford
changed the title
5 tasks
Agreed. Closing this PR in favor of #590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Having updated the raster bathymetry layer in #584, the "Depth contours" layer (the subject of this PR) is the only remaining Oceanography layer that does not have data covering the entire background boundary.
Currently, the "Depth contours" layer is obtained from the "Geological map of the Arctic / Carte gologique de l'Arctique" (2011) dataset, (the depth contours of which was based on the Bathymetric Chart of the Arctic Ocean (IBCAO)). The geological map dataset is used for our "Geology/Geological map" layers and the bathemetry contours are provided with the dataset for additional context.
Comparing contours in the geological map dataset to the current GEBCO grid shows some disagreement along the coasts. Given that the contours dataset seems to be outdated and only covers a portion of the Arctic, I figured I would use
gdal_contourto generate our own contours from the GEBCO 2023 grid added in PR #584. That's this PR.However, this dataset is a bit larger than our existing one on disk (~120M w/ a 500m contour interval instead of ~65M). Perhaps this is acceptable, but is there much benefit in even including this dataset? A user could use the processing toolbox to create their own contours layer from the "Depth (400m)" raster at any contour interval they desired. E.g., a 100m contour interval produces a file ~500M in size.
Checklist
If an item on this list is done or not needed, simply check it with
[x].inv config.export > qgreenland/config/cfg-lock.json)bumpversion (major|minor|patch|prerelease|build)