-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish docker image to GHCR and DockerHub #669
Conversation
* Remove mamba from docker image * Support micromamba-specific environment activation behavior * Stop mounting code into docker container * Add a dev compose file which mounts code
66b5b77
to
e13ef65
Compare
e13ef65
to
453b57e
Compare
Published the first https://github.com/nsidc/qgreenland/pkgs/container/qgreenland After publishing with this PR, I changed the workflow triggers so future PRs won't trigger publishes. |
Should only push images on tags (versions images) or main branch pushes ("latest").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments with suggestions but otherwise looks great!
Description
Build and publish docker images with GH Actions to GHCR and DockerHub
This entails some other changes; for example, we were always mounting code into containers with volumes. Now, we should have the correct version of the code baked in to the container.
Checklist
If an item on this list is done or not needed, simply check it with
[x]
.inv config.export > qgreenland/config/cfg-lock.json
)bumpversion (major|minor|patch|prerelease|build
)Fixes #542 , fixes #564