Style unit suffix validation #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trey-stafford re-writing these styles is a bit of tedium. May request to parallelize on this tomorrow :) |
MattF-NSIDC
commented
Aug 3, 2023
|
|
||
| def get_style_filepath(style_name: str) -> Path: | ||
| """Generate a Path object for style file represented by `style_name`.""" | ||
| return ANCILLARY_DIR / "styles" / (style_name + ".qml") |
There was a problem hiding this comment.
Migrated from _style_filepath in config/layer.py
MattF-NSIDC
force-pushed
the
style-unit-suffix-validator
branch
from
a47aa9a
to
0426ee5
Compare
MattF-NSIDC
commented
Aug 5, 2023
| TODO: Does not support large numbers well, adds commas where the QGIS symbology menu | ||
| does not. | ||
| formatter.formatNumber(float(-9902)) | ||
| >>> '-9,902' |
There was a problem hiding this comment.
I'm a bit frustrated running in to this after I thought I had things figured out. Is there any way to re-use QGIS' behavior for calculating these labels? What am I doing wrong?
There was a problem hiding this comment.
We decided to just check that a suffix was populated for linearly-interpolated colorramps, not actually check for consistency with item labels.
Calculating the suffix from QGIS' QML file is difficult. Let's just give up on that and do this the easier way.
Classification "mode" is how the values are classified: continuous, equal interval, and quantile. It doesn't matter which of these is chosen. What matters is the "Interpolation" setting. "Linear" is the only one that will display a continuous legend.
|
@trey-stafford got the docs updated now too |
Co-authored-by: Trey Stafford <trey.stafford@colorado.edu>
trey-stafford
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #685
TODO:
Checklist
If an item on this list is done or not needed, simply check it with
[x].inv config.export > qgreenland/config/cfg-lock.json)bumpversion (major|minor|patch|prerelease|build)