Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layer quality checklist to contributor docs #716

Merged
merged 9 commits into from
Aug 14, 2023

Conversation

MattF-NSIDC
Copy link

@MattF-NSIDC MattF-NSIDC commented Aug 9, 2023

⚠️ Please wait to merge this PR after merging #711, which includes a new document (disclaimer.md) this PR depends on. Merge main in to this branch to resolve the build failure.

Description

Closes #615

Checklist

If an item on this list is done or not needed, simply check it with [x].

  • Config lockfile updated (inv config.export > qgreenland/config/cfg-lock.json)
  • Version bumped if needed (bumpversion (major|minor|patch|prerelease|build)
  • CHANGELOG.md updated
  • Documentation updated if needed
  • New unit tests if needed

@MattF-NSIDC MattF-NSIDC changed the title Add layer quality checklist Add layer quality checklist to contributor docs Aug 9, 2023
Copy link
Contributor

@trey-stafford trey-stafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few thoughts/suggestions aimed at making this more friendly for community members who might be new to QGreenland.

doc/contributor/how-to/contribute-layers.md Outdated Show resolved Hide resolved
doc/contributor/how-to/contribute-layers.md Outdated Show resolved Hide resolved
doc/contributor/how-to/contribute-layers.md Outdated Show resolved Hide resolved
doc/contributor/how-to/contribute-layers.md Outdated Show resolved Hide resolved
doc/contributor/how-to/contribute-layers.md Show resolved Hide resolved
doc/contributor/how-to/contribute-layers.md Outdated Show resolved Hide resolved
doc/contributor/how-to/contribute-layers.md Outdated Show resolved Hide resolved
@MattF-NSIDC
Copy link
Author

RTD is failing:

/home/docs/checkouts/readthedocs.org/user_builds/qgreenland/checkouts/716/doc/contributor/how-to/contribute-layers.md:115: WARNING: 'myst' reference target not found: /disclaimer.md

It will pass once #711 is merged and this branch is updated from main.

@MattF-NSIDC MattF-NSIDC merged commit a64c943 into main Aug 14, 2023
2 checks passed
@MattF-NSIDC MattF-NSIDC deleted the layer-quality-checklist branch August 14, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add layer quality checklist(s) in the contributor documentation
3 participants