Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online-only GEUS geological map #725

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Conversation

trey-stafford
Copy link
Contributor

Description

WMS config for GEUS geological map. Addresses #566. We originally hoped to add the data itself to QGreenland, but it had some issues that made it difficult for us to add.

Checklist

If an item on this list is done or not needed, check it with [x] or click the
checkbox.

  • The PR description links to issues that it resolves with closes #{issue_number}
  • Config lockfile updated (inv config.export > qgreenland/config/cfg-lock.json)
  • Environment lockfile updated if needed (conda-lock)
  • Version bumped if needed (bumpversion (major|minor|patch|prerelease|build))
  • CHANGELOG.md updated
  • Documentation updated if needed
  • New unit tests if needed


Please download the legend for information on interpretation
of this layer:
https://maps.greenmin.gl/geusmapmore/greenlandportal/G500_2023_LEGEND.pdf .
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal, but this legend is really detailed and wouldn't really work in the layer panel anyway.

Copy link

@MattF-NSIDC MattF-NSIDC Aug 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That legend is a nightmare 😆

It's as big as the layer in the other PR I just approved (1.4M)!

@trey-stafford trey-stafford marked this pull request as ready for review August 15, 2023 16:06
@trey-stafford trey-stafford linked an issue Aug 15, 2023 that may be closed by this pull request
Copy link

@MattF-NSIDC MattF-NSIDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@trey-stafford trey-stafford merged commit f6c45a2 into main Aug 15, 2023
2 checks passed
@trey-stafford trey-stafford deleted the geus-geological-online-only branch August 15, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GEUS 1:500k geological map
2 participants