-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup OBE references to gdal_remote
and "Online" QgsLayerType
#728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think I'll get to this til tomorrow! |
MattF-NSIDC
reviewed
Aug 16, 2023
MattF-NSIDC
reviewed
Aug 16, 2023
MattF-NSIDC
approved these changes
Aug 16, 2023
💯 let's decouple these concepts. |
trey-stafford
commented
Aug 16, 2023
MattF-NSIDC
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Title. Related to #655.
The handling of the term "online" is a bit messy. For example, we have a function called
vector_or_raster
that is typed to return one of "Raster", "Vector", or "Online", but our mapping from provider -> layer type doesn't include "Online", sovector_or_raster
will only return what its function name indicates - "Vector" or "Raster".The only place we appear to use the "Online"
QgsLayerType
is in the export code that produces the layer csv. This puts "Online" in the "Vector or Raster" column for online layers! That seems confusing. Maybe a separate field for "On disk" that is true/false would be a better indicator. Online assets are still either vectors or rasters!This PR takes one step in the right direction by cleaning up OBE references to
gdal_remote
layers and removes "Online" from the list ofQgsLayerType
s. Instead, add in the unique "Online" behavior where it's used - in the export code!Checklist
If an item on this list is done or not needed, check it with
[x]
or click thecheckbox.
closes #{issue_number}
inv config.export > qgreenland/config/cfg-lock.json
)conda-lock
)bumpversion (major|minor|patch|prerelease|build)
)