Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access date to Natural Earth citations #745

Merged
merged 6 commits into from
Aug 18, 2023

Conversation

MattF-NSIDC
Copy link
Member

@MattF-NSIDC MattF-NSIDC commented Aug 18, 2023

Description

Closes #743

Checklist

If an item on this list is done or not needed, check it with [x] or click the
checkbox.

  • The PR description links to issues that it resolves with closes #{issue_number}
  • Config lockfile updated (inv config.export > qgreenland/config/cfg-lock.json)
  • Environment lockfile updated if needed (conda-lock)
  • Version bumped if needed (bumpversion (major|minor|patch|prerelease|build))
  • CHANGELOG.md updated (for user-facing changes)
  • Documentation updated if needed
  • New unit tests if needed

Change access date substitution code to include surrounding text for
consistency across our datasets
@MattF-NSIDC MattF-NSIDC marked this pull request as draft August 18, 2023 22:16
conda-lock seems to have carried these forward even after we moved them
from the `pip` section.
@MattF-NSIDC
Copy link
Member Author

Citation for NE layers look like:

Citation:
Made with Natural Earth [Accessed on: 2023-08-18]

@MattF-NSIDC MattF-NSIDC marked this pull request as ready for review August 18, 2023 22:23
Copy link
Contributor

@trey-stafford trey-stafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! One comment about text around the access date that we may want to consider first, but otherwise looks good.

qgreenland/config/datasets/soil_types.py Outdated Show resolved Hide resolved
tasks/config.py Show resolved Hide resolved
Co-authored-by: Trey Stafford <trey.stafford@colorado.edu>
@MattF-NSIDC MattF-NSIDC merged commit 8a77408 into main Aug 18, 2023
1 of 2 checks passed
@MattF-NSIDC MattF-NSIDC deleted the natural-earth-access-date branch August 18, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicate date of access for NE layers
3 participants