-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GrIMP ice velocity layers #749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the user guide, the actual data resolution "varies between a few hundred meters to 1.5 km".
Sticking to the annual mosaics for now, mostly for size-related reasons (annual layers add ~235M. Adding the quarterly data brings the total up to >1GB)
The color mapping for magnitude makes it difficult to represent the vectors on top of other layers with conflicting color maps.
Not required for styling the data any longer. Saves us some space too (GrIMP package size reduced to 333M from 342).
trey-stafford
added a commit
that referenced
this pull request
Aug 22, 2023
Magnitude is represented by the size of the vector lines. The color mapping was causing conflicts with other layers (like the raster of annual wind speed). This problem was discovered in: #749
trey-stafford
commented
Aug 22, 2023
qgreenland/config/layers/Glaciology/Ice sheet velocity/GrIMP/grimp.py
Outdated
Show resolved
Hide resolved
7 tasks
It looks like they're using both thickness and length. |
MattF-NSIDC
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Couple suggestions!
qgreenland/config/layers/Glaciology/Ice sheet velocity/GrIMP/grimp.py
Outdated
Show resolved
Hide resolved
qgreenland/config/layers/Glaciology/Ice sheet velocity/GrIMP/grimp.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Fisher <matt.fisher@nsidc.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #663.
Adds annual GrIMP ice velocity mosaic layers for 2021 under the "Glaciology/Ice sheet velocity/GrIMP" group:
In total, these GrIMP layers add ~342M to the uncompressed core package. Compressed, the QGreenland core package is ~3.1G.
Styling the ice velocity vectors
I applied the style from the wind vectors layer to get started. This worked fine, but led me to realize that our wind vectors have a colormap that's inverted compared to the raster representing wind speed. This is a conflict when the two layers are visualized together. That said, the fact that the colormap is inverted makes it easier to see the vectors on top of the velocity data!
I went ahead and reversed the color map for the ice velocity vectors and forced it to match the colormap for the ice velocity magnitude raster layer. This works pretty well, but visualizing the two together is problematic because the vectors blend in with the background raster and aren't visible. Maybe an outline around the vectors would be nice, but I haven't figured out how to do that yet.
Further, I downsampled the input data for creating the wind vectors to 1.5km. This makes rendering much faster than using the full resolution data and I think it looks better too. But the downside here is that areas with major changes in velocity result in intermediate-valued vectors that, when overlaid with the raster, look like smaller/larger values than the underlying raster. Maybe a better approach would be to create vectors at full-resolution, and then 'thin' the resulting vector dataset to reduce the number of lines actually displayed?
Based on how we decide to proceed here, we should apply similar styling to the wind vectors layer.
Checklist
If an item on this list is done or not needed, check it with
[x]
or click thecheckbox.
closes #{issue_number}
inv config.export > qgreenland/config/cfg-lock.json
)conda-lock
)bumpversion (major|minor|patch|prerelease|build)
)