Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

World Ocean Atlas 2023 salinity layers #769

Merged
merged 8 commits into from
Aug 23, 2023
Merged

Conversation

trey-stafford
Copy link
Contributor

Description

Add salinity layers from the World Ocean Atlas. These mirror the existing temperature layers from WOA (same depths and witner/summer seasonal averages).

Checklist

If an item on this list is done or not needed, check it with [x] or click the
checkbox.

  • The PR description links to issues that it resolves with closes #{issue_number}
  • Config lockfile updated (inv config.export > qgreenland/config/cfg-lock.json)
  • Environment lockfile updated if needed (conda-lock)
  • Version bumped if needed (bumpversion (major|minor|patch|prerelease|build))
  • CHANGELOG.md updated (for user-facing changes)
  • Documentation updated if needed
  • New unit tests if needed

@trey-stafford trey-stafford changed the title Woa23 salinity layers World Ocean Atlas 2023 salinity layers Aug 23, 2023
@trey-stafford
Copy link
Contributor Author

Adds ~2.1M to the package (uncompressed).

Copy link
Member

@MattF-NSIDC MattF-NSIDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor :)

@trey-stafford trey-stafford merged commit f042166 into main Aug 23, 2023
3 checks passed
@trey-stafford trey-stafford deleted the woa23-salinity-layers branch August 23, 2023 22:47
@trey-stafford
Copy link
Contributor Author

Resolves #510.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants