Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize internet-required layers #770

Merged
merged 6 commits into from
Aug 23, 2023
Merged

Conversation

MattF-NSIDC
Copy link

Description

Closes #727

Checklist

If an item on this list is done or not needed, check it with [x] or click the
checkbox.

  • The PR description links to issues that it resolves with closes #{issue_number}
  • Config lockfile updated (inv config.export > qgreenland/config/cfg-lock.json)
  • Environment lockfile updated if needed (conda-lock)
  • Version bumped if needed (bumpversion (major|minor|patch|prerelease|build))
  • CHANGELOG.md updated (for user-facing changes)
  • Documentation updated if needed
  • New unit tests if needed

@MattF-NSIDC MattF-NSIDC marked this pull request as ready for review August 23, 2023 22:41
Copy link
Contributor

@trey-stafford trey-stafford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggested change unrelated to your PR.

mfisher87 and others added 2 commits August 23, 2023 16:54
Co-authored-by: Trey Stafford <trey.stafford@colorado.edu>
@MattF-NSIDC
Copy link
Author

Waiting for more from @twilamoon-science in #727 before merge

@MattF-NSIDC
Copy link
Author

MattF-NSIDC commented Aug 23, 2023

@trey-stafford applied changes from discussion with Twila in #727

@MattF-NSIDC MattF-NSIDC merged commit 2b0bc2f into main Aug 23, 2023
1 check passed
@MattF-NSIDC MattF-NSIDC deleted the reorg-internet-required branch August 23, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-organize "Internet required" layers
3 participants