Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code for generating QGreenland plugin manifests #794

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MattF-NSIDC
Copy link

We don't want to build these anymore, and we also don't want to needlessly overwrite the existing manifest with one that may be incompatible with the plugin for whatever users do still dare to use it.

Checklist

If an item on this list is done or not needed, check it with [x] or click the
checkbox.

  • The PR description links to issues that it resolves with closes #{issue_number}
  • Config lockfile updated (inv config.export > qgreenland/config/cfg-lock.json)
  • Environment lockfile updated if needed (conda-lock)
  • Version bumped if needed (bumpversion (major|minor|patch|prerelease|build))
  • CHANGELOG.md updated (for user-facing changes)
  • Documentation updated if needed
  • New unit tests if needed

@MattF-NSIDC MattF-NSIDC marked this pull request as draft August 28, 2023 21:17
We don't want to build these anymore, and we also don't want to
needlessly overwrite the existing manifest with one that may be
incompatible with the plugin for whatever users do still dare to use it.
@MattF-NSIDC MattF-NSIDC force-pushed the remove-plugin-specific-build-behaviors branch from 30afb81 to e95100c Compare August 28, 2023 21:20
@MattF-NSIDC MattF-NSIDC marked this pull request as ready for review August 28, 2023 22:04
@MattF-NSIDC
Copy link
Author

#795 needs resolved for this PR to merge

@MattF-NSIDC MattF-NSIDC marked this pull request as draft August 28, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants