Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create user list view #69

Merged
merged 7 commits into from
Jul 31, 2023
Merged

Create user list view #69

merged 7 commits into from
Jul 31, 2023

Conversation

rmarow
Copy link
Contributor

@rmarow rmarow commented Jul 27, 2023

Resolves #64

@rmarow rmarow marked this pull request as ready for review July 27, 2023 21:50
@rmarow rmarow requested a review from MattF-NSIDC July 27, 2023 21:50
MattF-NSIDC
MattF-NSIDC suggested changes Jul 27, 2023
View reviewed changes
Copy link

@MattF-NSIDC MattF-NSIDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but would like a little bit of messaging if the user is not logged in and somehow makes it to that page. E.g. bookmarks it.

usaon_vta_survey/templates/users.html Outdated Show resolved Hide resolved
@rmarow rmarow requested a review from MattF-NSIDC July 27, 2023 22:51
MattF-NSIDC
MattF-NSIDC reviewed Jul 27, 2023
View reviewed changes
usaon_vta_survey/templates/users.html Outdated
{% block content %}
<h2>{% block title %}Users{% endblock %}</h1>

{% if not current_user.role=='admin' %}
Copy link

@MattF-NSIDC MattF-NSIDC Jul 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work as expected for logged out users? I'd expect an error like undefined has no attribute 'role'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this to reflect that.

MattF-NSIDC
MattF-NSIDC approved these changes Jul 27, 2023
View reviewed changes
Copy link

@MattF-NSIDC MattF-NSIDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my other comment; if this works as expected for both logged out users (I think this may be a problem) and non-admins, looks good to me!

@rmarow rmarow merged commit 576cf02 into main Jul 31, 2023
2 checks passed
@rmarow rmarow deleted the create_user_list_view branch July 31, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattF-NSIDC MattF-NSIDC MattF-NSIDC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create user list view for admins to see
2 participants
@rmarow @MattF-NSIDC