Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Consider update neo-go to v0.99.3 #35

Open
KirillovDenis opened this issue Sep 16, 2022 · 4 comments
Open

Consider update neo-go to v0.99.3 #35

KirillovDenis opened this issue Sep 16, 2022 · 4 comments
Assignees
Labels
blocked This issue is blocked by something enhancement New feature or request P3 Low

Comments

@KirillovDenis
Copy link

It would be nice to update neo-go to v0.99.3 and replace deprecated code. https://github.com/nspcc-dev/neo-go/releases/tag/v0.99.3
But probably there is some problem with go version 1.16 in go.mod

@KirillovDenis
Copy link
Author

Wait for NNS wrapper in neo-go

Currently only NEP11 is supported (we need more)

@alexvanin
Copy link

@AnnaShaleva What you think about having wrappers for side chain NNS (from neofs-contract) in neo-go library? Is it possible? If so, then maybe you have some estimations?

@AnnaShaleva
Copy link
Member

having wrappers for side chain NNS (from neofs-contract) in neo-go library

Currently we have nspcc-dev/neo-go#2732 for the mainnet's one, it is planned to be included in the next post-3.5.0-compatible release, but it still differs from the side chain NNS and I don't have any estimations on neo-project/non-native-contracts#25 (comment) progress.

Is it possible?

Since there's no progress on NNS API unification, I'm afraid the only option we have now is to add another NNS wrapper that will be compatible with the side chain NNS. But I'm not sure that supporting of two NNS versions is what we want. @roman-khimov, what do you think?

I'd still vote for adding this wrapper (and remove it once all NNS APIs are in sync).

@roman-khimov
Copy link
Member

I think it's easier to autogenerate one and keep it in neofs-contracts. We will probably have NNS wrapper in NeoGo, but that'd be the mainnet version. I'd like that to also be kept outside of the main repo, but unfortunately that'd mean a circular repository dependency for us (we'll need to use it in the CLI).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked This issue is blocked by something enhancement New feature or request P3 Low
Projects
None yet
Development

No branches or pull requests

4 participants