-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Go 1.21 #237
Upgrade to Go 1.21 #237
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
==========================================
- Coverage 22.08% 21.88% -0.21%
==========================================
Files 17 17
Lines 3319 3583 +264
==========================================
+ Hits 733 784 +51
- Misses 2450 2639 +189
- Partials 136 160 +24 ☔ View full report in Codecov by Sentry. |
9be0e57
to
ee833ca
Compare
CHANGELOG.md
Outdated
- github.com/nspcc-dev/neo-go dependency from v0.106.0 to v0.106.3 (#98) | ||
- github.com/testcontainers/testcontainers-go dependency from v0.25.0 to v0.32.0 (#98) | ||
- github.com/oapi-codegen/echo-middleware dependency from v1.0.1 to v1.0.2 (#98) | ||
- github.com/labstack/echo/v4 dependency from v4.11.4 to v4.12.0 (#98) | ||
- github.com/getkin/kin-openapi from v0.118.0 to v0.127.0 (#98) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that all these package updates should be mentioned in the CHANGELOG. I'd rather add something like "Upgraded Go version to a minimum of 1.21" in the "Changed" section and leave it at that.
But I don't insist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These can affect gateway functionality (something like testcontainers can't, so those can be omitted, but it's not a hard requirement to me).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the policy for supported versions, please mention that in commits.
Closes #98. Updated Go version support policy nspcc-dev/.github#30. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Refs #230. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
ee833ca
to
705ca12
Compare
Added link to the new policy |
Closes #98