Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.21 #237

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Upgrade to Go 1.21 #237

merged 5 commits into from
Aug 19, 2024

Conversation

smallhive
Copy link
Contributor

Closes #98

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 21.88%. Comparing base (f093ac5) to head (705ca12).
Report is 20 commits behind head on master.

Files Patch % Lines
cmd/neofs-rest-gw/config.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   22.08%   21.88%   -0.21%     
==========================================
  Files          17       17              
  Lines        3319     3583     +264     
==========================================
+ Hits          733      784      +51     
- Misses       2450     2639     +189     
- Partials      136      160      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smallhive smallhive force-pushed the 98-go-121-upgrade-check-list branch from 9be0e57 to ee833ca Compare August 16, 2024 10:52
CHANGELOG.md Outdated
Comment on lines 11 to 15
- github.com/nspcc-dev/neo-go dependency from v0.106.0 to v0.106.3 (#98)
- github.com/testcontainers/testcontainers-go dependency from v0.25.0 to v0.32.0 (#98)
- github.com/oapi-codegen/echo-middleware dependency from v1.0.1 to v1.0.2 (#98)
- github.com/labstack/echo/v4 dependency from v4.11.4 to v4.12.0 (#98)
- github.com/getkin/kin-openapi from v0.118.0 to v0.127.0 (#98)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that all these package updates should be mentioned in the CHANGELOG. I'd rather add something like "Upgraded Go version to a minimum of 1.21" in the "Changed" section and leave it at that.
But I don't insist.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can affect gateway functionality (something like testcontainers can't, so those can be omitted, but it's not a hard requirement to me).

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the policy for supported versions, please mention that in commits.

Closes #98.

Updated Go version support policy nspcc-dev/.github#30.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Refs #230.

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive force-pushed the 98-go-121-upgrade-check-list branch from ee833ca to 705ca12 Compare August 19, 2024 10:02
@smallhive
Copy link
Contributor Author

smallhive commented Aug 19, 2024

Added link to the new policy

@smallhive smallhive requested a review from roman-khimov August 19, 2024 10:02
@roman-khimov roman-khimov merged commit 22345ff into master Aug 19, 2024
12 of 14 checks passed
@roman-khimov roman-khimov deleted the 98-go-121-upgrade-check-list branch August 19, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Go 1.21 upgrade check list
3 participants