Change payload file path #92
Conversation
Without this change, when running simultaneously, the size of the objects being written may be incorrect. Signed-off-by: EESergey <s.eremenko@nspcc.io>
EESergey
requested review from
roman-khimov,
smallhive and
tatiana-nspcc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #92 +/- ##
======================================
Coverage 2.20% 2.20%
======================================
Files 11 11
Lines 725 725
======================================
Hits 16 16
Misses 709 709 ☔ View full report in Codecov by Sentry. |
|
Please add |
The file is created in the /tmp directory and other users do not have write access. To avoid unwanted interference, the file is moved to the home directory. Signed-off-by: EESergey <s.eremenko@nspcc.io>
scenarios/preset/preset_grpc.py
Outdated
| @@ -33,7 +33,7 @@ | |||
| def main(): | |||
| container_list = [] | |||
| objects_struct = [] | |||
| payload_filepath = '/tmp/data_file' | |||
| payload_filepath = '/tmp/data_file_' + args.size + 'k' | |||
There was a problem hiding this comment.
i guess the problem you saw here was caused by a general mistake: this script was not expected to be used simultaneously. if we are trying to solve it, can we add some more unique data to the name (e.g. time?). if you are already running it for different sizes in parallel, i will not be surprised if some time in the future somebody will try to run it for two different networks or for two different object sets but with the same size, etc
There was a problem hiding this comment.
If the size is correct, then I don't see a problem with it.
To solve the problem with rights, I moved this file to the home directory.
|
A few more changes need to be made. |
Without this change, when running simultaneously, the size of the objects being written may be incorrect.